Initial code for a website #1
Conversation
|
I'm not sure github pages is cool with the content being under 'site'. Also, this seems to be the default layout for jekyll. Maybe we want to wait to accept a pull request with the content as well as the layout? |
|
Thx cestella. This is temporary. Eventually it will go somewhere else like gh-pages. I am adding the content today/tonight and doing another push. |
|
Also this is for the Apache website not the github project page doc for which we need gh-pages or something .... |
|
Yes .... we could wait for 1-2 days for the layout and some base content On Wed, Dec 9, 2015 at 2:16 PM, Casey Stella notifications@github.com
-Debo~ |
|
This isn't github pages, it is using the same tools (ie. Jekyll) as github pages to produce the html. Apache doesn't care how you produce the html, we just need to check the generated html into the asf-site branch and it will auto-magically replicate to http://metron.incubator.apache.org/ |
|
You should probably create an empty branch (named "site" maybe?) that has the source code for the site. I tried to build the site from your pull request, but it fails needs a Gemfile and with a missing header on the _posts/2015-12-09-welcome-to-jekyll.markdown. |
|
I ran into that as well. Definitely need the Gemfile, but if you run jekyll On Thu, Dec 10, 2015 at 12:37 omalley notifications@github.com wrote:
|
|
By the way, I filed METRON-1 for this. :) |
|
Thats very coool! |
|
Could someone please review the pull request? Instructions to build it are in BUILD.md |
|
+1. Works and looks like a good starting point. |
|
[METRON-1] |
|
Why don't you pick one of the logos for now and update it when the community picks one in a few days? You should fix the link the slides and use: http://www.slideshare.net/JamesSirota/cisco-opensoc I guess for videos, I'd use: I'd suggest changing the highlights to blue. |
|
Oh, you also have the ORC twitter on the news page, which probably not what you want. :) |
|
The link to the jira should be: https://issues.apache.org/jira/browse/metron The correct user mailing list for the "help" page is: user@metron.incubator.apache.org The mailing lists on the "develop" page need to be updated. |
|
Thans a lot of for the comment Owen. The idea was to do small commits and get the baseline site merged. Then fix a lot of the content. Will do another commit tonight. |
|
I left a comment on the JIRA. In general, are we commenting on pull requests or the JIRA? They don't seem to be autopopulating between the two systems and this could get confusing fast. |
|
Many people might not have access to JIRA while everyone should be able to comment on github. What should we use? |
|
Everyone should have the ability to comment or submit a JIRA. On Tue, Dec 15, 2015 at 11:03 AM, ddutta notifications@github.com wrote:
|
|
Just posed something to the dev list about this. Send me your ID and I'll add you |
|
JIRA ID=ddutta |
|
Done. can you verify you have all the permissions you need? |
|
Done with the basic changes suggested by Owen. Please review. |
|
I looked at the site, looks much better. I had a couple comments:
|
|
Thx cestella
|
|
cestella: if you compare with the orc's directory structure, there is a directory called site for the code. Then there is a branch called asf_site where the generated HTML code is checked in. I have mimicked that. Did you by any chance see the asf_site under your directory? If so thats the generated code when you run jekyll. |
|
Right, but if you look what's showing currently in http://metron.incubator.apache.org/, it's the index.html which is at the root of the asf-site branch. Also, if you look at orc's git structure, the ASF branch has what is in effect the content of what's in the site directory here. I'm not sure what the purpose of site directory is in the master branch for orc. |
|
Yes I need to check the generated files (from the asf_site target) into the asf_site branch of current code base. Then it will auto update. |
|
Ahh, I get it. There will be a followup pull request with that patch. Got it. |
|
Thx for all your feedback .... hope you can +1 this and merge now. |
|
I just did a clean clone locally and downloaded the patch for the pull request (https://github.com/apache/incubator-metron/pull/1.patch) and applied it (via git apply) and I'm seeing site/_posts/2015-12-09-welcome-to-jekyll.markdown Can you confirm you see that? |
|
I see it when I apply the patch but can't figure out why my commits are not getting applied to the patch of the pull request. |
|
@cestella the asf-site branch is the output of jekyll. We can have the input to jekyll either in a site directory on the master branch or create a separate branch for the jekyll source. It works either way. Unlike github, the project is required to manually run jekyll and push the output to asf-site. |
|
cestella, once this is merged I will clean up the rest. |
|
Ok, sounds good. it has my +1 then |
|
Thx! |
|
I'd actually suggest creating a little news item for getting accepted to incubator. |
|
Oh, you can grab the committer list from: |
|
Alright, I merged this pull request. This should close automatically. |
|
Thx! On Thu, Dec 17, 2015 at 11:04 AM, Casey Stella notifications@github.com
-Debo~ |
Bug 70448: Extra Storm topology status call is unnecessarily added for each new sensor created
Fixing mock test infrastructure to handle batch and randomaccess index topologies
Add backend integration and add license headers
6 participants
Base code from Jekyll. Working on incorporating the layout from ORC's pages. Also need a logo.