Fix R build crash in CI#9965
Conversation
|
Thanks a lot! |
|
Thanks sheng
Sheng Zha <notifications@github.com> schrieb am Fr., 2. März 2018, 22:23:
… Merged #9965 <#9965>.
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#9965 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARxB64TlptuCY5tU5BU_gTRGxsDahXZbks5tabhLgaJpZM4SaWvc>
.
|
|
|
||
| graph<- create_graph(nodes_df = nodes_df_new, edges_df = edge_df_new, directed = TRUE) %>% | ||
| set_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% | ||
| add_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% |
There was a problem hiding this comment.
This is not the ideal fix though IMO. MXNet should still be able to run under DiagrammeR = 0.9.0. You should be able to check the version and trigger the methods properly based on different versions of DiagrammeR.
There was a problem hiding this comment.
This will potentially lose users who cannot afford to upgrade their DiagrammeR at the moment due to large codebases.
There was a problem hiding this comment.
Wouldn't it rather make sense to pin the version to 0.9.0 - 0.9.2?
There was a problem hiding this comment.
Or what do you think, @jeremiedb ? 0.9 sounds like an unstable beta version, so maybe it would make sense to tell users to upgrade? But we would also have to consider SemVer, so this might be difficult.
There was a problem hiding this comment.
Yes, agree that works in this case but I guess I was just commenting in general that this should be something to consider.
There was a problem hiding this comment.
Agree that I may have been too conservative with the 1.0.0 requirement. I just made a slight modification and graphs can now be rendered as before even on 0.9.0.
* fix viz.graph R * fix viz.graph R
* fix viz.graph R * fix viz.graph R
* fix viz.graph R * fix viz.graph R
* fix viz.graph R * fix viz.graph R
* fix viz.graph R * fix viz.graph R
* fix viz.graph R * fix viz.graph R
4 participants
Fix for #9957
Resolves the deprecated function in DiagrammeR package used in graph.viz.
Graph nodes are now of fixed size rather than adapting to wrap the whole text, I will check for a solution to this in the next days.