Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

R fix#9999

Merged
marcoabreu merged 2 commits intoapache:v1.1.0from
nswamy:r-fix
Mar 6, 2018
Merged

R fix#9999
marcoabreu merged 2 commits intoapache:v1.1.0from
nswamy:r-fix

Conversation

@nswamy
Copy link
Copy Markdown
Member

@nswamy nswamy commented Mar 5, 2018

Description

Cherry picked commits that resolve R builds onto v.1.1.0

bce00aa
f973fe0

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@nswamy nswamy requested a review from thirdwing as a code owner March 5, 2018 23:20
@nswamy nswamy requested a review from marcoabreu March 5, 2018 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants