This repository was archived by the owner on Nov 17, 2023. It is now read-only.
revert DiagrammeR compatibility to 0.9.0#9975
Merged
marcoabreu merged 1 commit intoapache:masterfrom Mar 5, 2018
jeremiedb:graphR2
Merged
revert DiagrammeR compatibility to 0.9.0#9975marcoabreu merged 1 commit intoapache:masterfrom jeremiedb:graphR2
marcoabreu merged 1 commit intoapache:masterfrom
jeremiedb:graphR2
Conversation
Contributor
|
Is this still compatible with 1.0.0? |
Contributor
Author
|
Yes, tested compatibility with DiagrammeR 0.9.0 and 1.0.0. |
Contributor
|
@jeremiedb could you please apply these changes to branch 1.0.0 and 1.1.0? |
nswamy
pushed a commit
to nswamy/incubator-mxnet
that referenced
this pull request
Mar 5, 2018
nswamy
pushed a commit
to nswamy/incubator-mxnet
that referenced
this pull request
Mar 5, 2018
nswamy
pushed a commit
to nswamy/incubator-mxnet
that referenced
this pull request
Mar 5, 2018
marcoabreu
pushed a commit
that referenced
this pull request
Mar 6, 2018
Merged
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
Mar 30, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow comments to maintain compatibility with 0.9.0: #9965
attr_theme = NULLis the only material change along the DESCRIPTION requirement. Other changes are just syntax fix.