Skip to content

Conversation

@hotislandn
Copy link
Contributor

Signed-off-by: hotislandn hotislandn@hotmail.com

This is a patch for RV64 elf relcateadd handler which is copied from RV32.

.

…LO12_S.

Signed-off-by: hotislandn <hotislandn@hotmail.com>
@hotislandn
Copy link
Contributor Author

BTW,this file is almost the same for rv32 and rv64, how about merging them into one, and put into a common folder under risc-v?

Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xiaoxiang781216 xiaoxiang781216 merged commit d9a1b67 into apache:master Feb 15, 2021
@xiaoxiang781216
Copy link
Contributor

BTW,this file is almost the same for rv32 and rv64, how about merging them into one, and put into a common folder under risc-v?

Yes, it is in the plan, please see: #2593, #2594 and #2822.
Could you provide a PR to merge llibs/libc/machine/risc-v?

@hotislandn hotislandn deleted the rv64_elf_R_RISCV_LO12_S branch February 18, 2021 06:10
@hotislandn
Copy link
Contributor Author

Sure. I would like to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants