-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Changed Docker Maven plugin from Spotify to fabric8 #16099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@merlimat Please provide a correct documentation label for your PR. |
nicoloboschi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michaeljmarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Re-open this PR to rerun the test. |
|
@merlimat Could you please check the failed test? |
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
CI is failing while building the docker image. maybe we have to fine tune this patch
|
Motivation
The maven plugin
com.spotify:dockerfile-maven-pluginthat we are using to build Docker images has been discontinued and not supported for quite some time. There are also things that don't work anymore with this plugin, like for example building on M1 Mac with an ARM based JVM.The suggested replacement is
io.fabric8:docker-maven-plugin(https://dmp.fabric8.io) which is actively mantained.doc-not-needed