[WIP][ci] Change packaging plugin from dockerfile-maven-plugin to docker-maven-plugin

[skyleaworlder]

Fixes #16652

Motivation

dockfile-maven-plugin is archived now, and it doesn't perform on M1 as @tisonkun says.

Modifications

I choose docker-maven-plugin to replace docker-maven-plugin.

Verifying this change

• Make sure that the change passes the CI checks.

This PR don't pass CI in my fork repo, because it seems that workflows related to "build-docker" were not invoked. So I might need some help.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): yes
• The public API: no
• The schema: no
• The default values of configurations: no
• The wire protocol: no
• The rest endpoints: no
• The admin cli options: no
• Anything that affects deployment: yes

Documentation

Check the box below or label this PR directly.

Need to update docs?

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed

All docs are available here.

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[tisonkun]

cc @lhotari could you check whether this change is in a good direction?

If so, please help trigger the CI workflow.

[merlimat]

@skyleaworlder I had tried to work on this in #16099 though there were some issues that I didn't get time to fix. Can you check and compare both PRs?

[skyleaworlder]

@skyleaworlder I had tried to work on this in #16099 though there were some issues that I didn't get time to fix. Can you check and compare both PRs?

It's my pleasure. I have checked changes in #16099. I find some tags (registry or latest version) loss compared to dockerfile-maven-plugin version.

I've also checked failed workflows' result and I find https://repository.apache.org/snapshots/org/apache/pulsar/pulsar-docker-image/2.11.0-SNAPSHOT/pulsar-docker-image-2.11.0-SNAPSHOT-docker-info.jar is not available. But I don't know why others (e.g. here) have the same workflow.yaml passed.

     <dependencies>
        <dependency>
          <groupId>${project.groupId}</groupId>
          <artifactId>pulsar-docker-image</artifactId>
          <version>${project.version}</version>
          <classifier>docker-info</classifier>
        </dependency>
     </dependencies>

[tisonkun]

I've also checked failed workflows' result and I find https://repository.apache.org/snapshots/org/apache/pulsar/pulsar-docker-image/2.11.0-SNAPSHOT/pulsar-docker-image-2.11.0-SNAPSHOT-docker-info.jar is not available. But I don't know why others (e.g. here) have the same workflow.yaml passed.

Generally if you cannot resolve an artifact from remote server, it should fallback to local maven repository and find it.

[tisonkun]

If you cannot find it locally, it's possibly that the execution generate the snapshot doesn't execute before the failure execution gets executed.

[tisonkun]

I'm going to work on this issue in the following weeks and see if I can offer some help.

[tisonkun]

It seems docker-info is something specific to dockerfile-maven-plugin and we can remove it.

Reference: https://stackoverflow.com/questions/52033059/maven-dockerfile-plugin-not-able-to-tag-the-image

[skyleaworlder]

I'm going to work on this issue in the following weeks and see if I can offer some help.

Sorry I just saw this message and I have to say that I have little time to track this issue in the following days. 😢

[tisonkun]

@skyleaworlder never mind. Your patch is a good starting point. If you return here later and find the issue still open, you can continue it. Or you're always welcome to contribute to Apache Pulsar :)