[CI] Remove usage of diff-only action with paths-ignore #9527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
changed the title
- diff-only has a critical bug apache/pulsar-test-infra#12 which is also reported as apache#9526 - GitHub Actions has paths-ignore feature which makes diff-only action obsolete - docs for paths-ignore: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths
lhotari
force-pushed
the
lh-replace-skip-tests-for-docs-solution
branch
from
4bbcd0e to
873c1ee
Compare
zymap
requested review from
aahmed-se,
codelipenghui,
jiazhai,
sijie and
zymap
and removed request for
aahmed-se and
zymap
jiazhai
approved these changes
Feb 9, 2021
Member
|
This PR causes problems that website-only changes are not able to be merged anymore. I am going to revert this change first. |
sijie
added a commit
to sijie/pulsar
that referenced
this pull request
Feb 17, 2021
…)" This reverts commit 40a1621.
This was referenced Feb 17, 2021
Closed
zymap
added a commit
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9526
Motivation
diff-onlyhas a critical bug Pulsar PR didn't run test after commit pulsar-test-infra#12which is also reported as CI is not running tests #9526
GitHub Actions has paths-ignore feature which makes the
diff-onlyaction obsoleteModifications
diff-onlywith the usage ofpaths-ignore