Revert "Remove usage of diff-only action with paths-ignore (#9527)" #9606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This pull request is blocked by #9607 |
Member
|
Yes, the paths-ignore property doesn't seem to work as expected. One replacement is https://github.com/marketplace/actions/skip-duplicate-actions#skip-ignored-paths however I agree that it's good to revert back to diff-only action until we have a replacement. I'll propose a replacement in the GitHub Actions workflow refactoring that I'm working on. |
merlimat
approved these changes
Feb 18, 2021
zymap
approved these changes
Feb 22, 2021
Member
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#9527 introduced a regression causing website-only changes are not able to be merged because all CI tasks are ignored by path-ignore settings.
This PR reverts the change and increases the clone depth from 25 to 100 to temporarily mitigate the problem that #9527 tried to fix.
We shouldn't remove diff-only action until we find a better solution.