Skip to content

Conversation

@pointearth
Copy link
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@sijie
Copy link
Member

sijie commented Feb 16, 2021

@pointearth Thank you for your contribution! Glad to see more companies adopting Pulsar!

@sijie sijie added this to the 2.8.0 milestone Feb 16, 2021
@sijie sijie closed this Feb 16, 2021
@sijie sijie reopened this Feb 16, 2021
@codelipenghui
Copy link
Contributor

@pointearth Seem the changes are not based on the latest master branch, could you please rebase to the master branch? So that the CI can works.

@sijie
Copy link
Member

sijie commented Feb 17, 2021

@codelipenghui This CI is not running due to #9527. I reverted the changes in #9606. Please review it and let's get the change merged first to unblock CI.

@codelipenghui
Copy link
Contributor

@pointearth Sorry, I want to close the PR and reopen it to trigger the CI, but I don't know why I can't reopen it.

@codelipenghui
Copy link
Contributor

I merged #9604 first since the CI passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants