fix: test errors and warnings - iteration 2 (#12212)

[michael-s-molina]

SUMMARY

Remove tests errors and warnings to improve results readability.

The following errors and warnings have been removed:

Warning: Failed prop type: Invalid prop `option` supplied to `MetricDefinitionValue`.

spec/javascripts/explore/components/MetricsControl_spec.jsx

Error: Not implemented: navigation (except hash changes)

spec/javascripts/components/AlteredSliceTag_spec.jsx

Warning: Unmatched <HTTP_METHOD> to <URL>

spec/javascripts/explore/components/SaveModal_spec.jsx
spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx

Warning: Each child in a list should have a unique "key" prop.

spec/javascripts/explore/components/SelectControl_spec.jsx
spec/javascripts/explore/components/SelectControl_spec.jsx

Warning: Failed prop type: The prop `dashboardId` is marked as required in `ChartHolder`, 
but its value is `undefined`.

spec/javascripts/dashboard/components/gridComponents/ChartHolder_spec.jsx

Warning: Failed prop type: The prop `slice` is marked as required in `Chart`, but its value is `undefined`.

spec/javascripts/dashboard/components/gridComponents/ChartHolder_spec.jsx

Warning: Failed prop type: The prop `filters` is marked as required in `Tab`, but its value is `undefined`.

spec/javascripts/dashboard/components/gridComponents/Tab_spec.jsx

Warning: Failed prop type: The prop `setDirectPathToChild` is marked as required in `Tab`, 
but its value is `undefined`.

spec/javascripts/dashboard/components/gridComponents/Tab_spec.jsx

Error: fetch-mock: No fallback response defined for <HTTP_METHOD> to <URL>

spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx
spec/javascripts/explore/components/EmbedCodeButton_spec
spec/javascripts/explore/components/SaveModal_spec.jsx
spec/javascripts/sqllab/QuerySearch_spec.jsx
spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx

Warning: Failed prop type: The prop `savedMetric.metric_name` is marked as required 
in `AdhocMetricEditPopover`,  but its value is `undefined`.

spec/javascripts/explore/components/AdhocFilterControl_spec.jsx

UnhandledPromiseRejection: This error originated either by throwing inside of an async function
without a catch block, or by rejecting a promise which was not handled with .catch().

spec/javascripts/explore/components/EmbedCodeButton_spec

When testing, code that causes React state updates should be wrapped into act(...)

spec/javascripts/explore/components/EmbedCodeButton_spec
spec/javascripts/messageToasts/components/Toast_spec.jsx
spec/javascripts/views/CRUD/data/database/DatabaseModal_spec.jsx

Warning: Failed prop type: Invalid prop `option` supplied to `MetricDefinitionValue`.

spec/javascripts/explore/components/MetricsControl_spec.jsx

#12212

@rusackas @junlincc @villebro

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12214 (f9c1dd8) into master (b1c203b) will increase coverage by 3.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12214      +/-   ##
==========================================
+ Coverage   62.86%   66.66%   +3.80%     
==========================================
  Files        1018     1018              
  Lines       49771    49790      +19     
  Branches     4875     4875              
==========================================
+ Hits        31289    33194    +1905     
+ Misses      18284    16473    -1811     
+ Partials      198      123      -75     

Flag	Coverage Δ
cypress	50.95% <ø> (?)
javascript	61.41% <ø> (+0.45%)	⬆️
python	63.67% <ø> (-0.46%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engines/hive.py	0.00% <0.00%> (-85.72%)	⬇️
superset/db_engine_specs/hive.py	54.61% <0.00%> (-29.24%)	⬇️
superset/db_engine_specs/presto.py	81.38% <0.00%> (-6.71%)	⬇️
superset/views/database/mixins.py	80.70% <0.00%> (-1.76%)	⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx	84.14% <0.00%> (-1.04%)	⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx	74.71% <0.00%> (-0.87%)	⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx	76.08% <0.00%> (-0.84%)	⬇️
superset/models/core.py	88.04% <0.00%> (-0.82%)	⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx	60.41% <0.00%> (-0.64%)	⬇️
...tend/src/views/CRUD/annotation/AnnotationModal.tsx	66.14% <0.00%> (-0.53%)	⬇️
... and 194 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c203b...f9c1dd8. Read the comment docs.

[rusackas]

LGTM! Thanks for all the cleanup!