fix: tests errors and warnings - iteration 3 (#12212)#12219
Conversation
75430db to
446991f
Compare
|
@michael-s-molina it seems CI is either really slow or stuck (noticed the same on your other PR). I'll check back later to see if CI has started. |
|
@villebro CI is stuck in all PRs. I noticed that yesterday. |
|
@michael-s-molina whoah, this is quite the traffic jam.. |
446991f to
61de397
Compare
Codecov Report
@@ Coverage Diff @@
## master #12219 +/- ##
==========================================
- Coverage 66.79% 66.72% -0.07%
==========================================
Files 1015 1017 +2
Lines 49676 49734 +58
Branches 4847 4864 +17
==========================================
+ Hits 33183 33187 +4
- Misses 16371 16424 +53
- Partials 122 123 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
61de397 to
46be65c
Compare
rusackas
left a comment
There was a problem hiding this comment.
LGTM! Again, thank you for the detailed description, and thank you for splitting it into multiple PRs!
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...

SUMMARY
Remove tests errors and warnings to improve results readability.
The following errors and warnings have been removed:
#12212
@rusackas @junlincc @villebro
ADDITIONAL INFORMATION