fix: tests errors and warnings - iteration 4 (#12212)#12223
Merged
rusackas merged 1 commit intoJan 26, 2021
Conversation
147954d to
eb009e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #12223 +/- ##
==========================================
- Coverage 64.55% 62.77% -1.79%
==========================================
Files 1018 1018
Lines 49787 49775 -12
Branches 4971 4877 -94
==========================================
- Hits 32141 31246 -895
- Misses 17468 18329 +861
- Partials 178 200 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2db2819 to
9d79acf
Compare
9d79acf to
25997e3
Compare
rusackas
approved these changes
Jan 26, 2021
Member
rusackas
left a comment
There was a problem hiding this comment.
LGTM! BTW, thank you for the great issue description for all of these! It really helps parsing the rationale behind the code I'm looking at.
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove tests errors and warnings to improve results readability.
The following errors and warnings have been removed:
#12212
@rusackas @junlincc @villebro
ADDITIONAL INFORMATION