Skip to content

fix: add alerts and report to default config#12999

Merged
dpgaspar merged 1 commit into
apache:masterfrom
preset-io:fix/alerts-config
Feb 9, 2021
Merged

fix: add alerts and report to default config#12999
dpgaspar merged 1 commit into
apache:masterfrom
preset-io:fix/alerts-config

Conversation

@dpgaspar
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar commented Feb 8, 2021

SUMMARY

Adds alerts and reports beat schedule by default (basically helps our users)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 8, 2021

Codecov Report

Merging #12999 (c3f4dc3) into master (9cc38ac) will increase coverage by 3.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12999      +/-   ##
==========================================
+ Coverage   63.21%   66.97%   +3.76%     
==========================================
  Files        1025      489     -536     
  Lines       50291    28756   -21535     
  Branches     5241        0    -5241     
==========================================
- Hits        31790    19259   -12531     
+ Misses      18289     9497    -8792     
+ Partials      212        0     -212     
Flag Coverage Δ
javascript ?
python 66.97% <ø> (+2.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.64% <ø> (ø)
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/dataframe.py 91.66% <0.00%> (-8.34%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/base.py 79.85% <0.00%> (-6.39%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
... and 570 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc38ac...c3f4dc3. Read the comment docs.

@nytai
Copy link
Copy Markdown
Member

nytai commented Feb 8, 2021

Is docker-compose running beat or celery with the -B flag?

Copy link
Copy Markdown
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. We should add some more docs and/or configs so users know how to run alerts and reports. We can address in another PR.

@dpgaspar dpgaspar merged commit 8b2df52 into apache:master Feb 9, 2021
@dpgaspar dpgaspar deleted the fix/alerts-config branch February 9, 2021 15:33
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Feb 10, 2021
* master:
  fix: UI toast typo (apache#13026)
  feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602)
  fix(build): black failing on master, add to required checks (apache#13039)
  fix: time filter db migration optimization (apache#13015)
  fix: untranslated text content of Dashboard page (apache#13024)
  fix(ci): remove signature requirements for commits to master (apache#13034)
  fix: add alerts and report to default config (apache#12999)
  docs(changelog): add entries for 1.0.1 (apache#12981)
  ci: skip cypress if no code changes (apache#12982)
  chore: add cypress required checks for branch protection (apache#12970)
  Refresh dashboard list after bulk delete (apache#12945)
  Updates storybook to version 6.1.17 (apache#13014)
  feat: Save datapanel state in local storage (apache#12996)
  fix: added text and changed margins (apache#12923)
  chore: Swap Slack Url 2 more places (apache#13004)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants