fix: UI toast typo#13026
Merged
Merged
Conversation
villebro
reviewed
Feb 9, 2021
| setLoading(false); | ||
| addDangerToast( | ||
| `There was an issue fetching your recent acitivity: ${e}`, | ||
| `There was an issue fetching your recent activity: ${e}`, |
villebro
approved these changes
Feb 9, 2021
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM. Not sure what the convention on super short variable names, but while we're at it, perhaps we could also replace e with errMsg or similar that's used in many other places in the code base.
Codecov Report
@@ Coverage Diff @@
## master #13026 +/- ##
===========================================
+ Coverage 52.64% 72.97% +20.32%
===========================================
Files 480 546 +66
Lines 17300 20175 +2875
Branches 4481 5268 +787
===========================================
+ Hits 9108 14723 +5615
+ Misses 8192 5327 -2865
- Partials 0 125 +125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
pushed a commit
to simcha90/incubator-superset
that referenced
this pull request
Feb 10, 2021
* master: fix: UI toast typo (apache#13026) feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602) fix(build): black failing on master, add to required checks (apache#13039) fix: time filter db migration optimization (apache#13015) fix: untranslated text content of Dashboard page (apache#13024) fix(ci): remove signature requirements for commits to master (apache#13034) fix: add alerts and report to default config (apache#12999) docs(changelog): add entries for 1.0.1 (apache#12981) ci: skip cypress if no code changes (apache#12982) chore: add cypress required checks for branch protection (apache#12970) Refresh dashboard list after bulk delete (apache#12945) Updates storybook to version 6.1.17 (apache#13014) feat: Save datapanel state in local storage (apache#12996) fix: added text and changed margins (apache#12923) chore: Swap Slack Url 2 more places (apache#13004)
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 14, 2021
* fix: UI toast typo * translate * fix error msg
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* fix: UI toast typo * translate * fix error msg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes small typo and message toast handling
Before:
After:
ADDITIONAL INFORMATION