Skip to content

fix(ci): remove signature requirements for commits to master#13034

Merged
nytai merged 1 commit into
apache:masterfrom
preset-io:tai/fix-signing-req
Feb 9, 2021
Merged

fix(ci): remove signature requirements for commits to master#13034
nytai merged 1 commit into
apache:masterfrom
preset-io:tai/fix-signing-req

Conversation

@nytai
Copy link
Copy Markdown
Member

@nytai nytai commented Feb 9, 2021 •
edited
Loading

SUMMARY

  • I misunderstood how this asf.yaml setting works when I suggested enabling it in chore: add cypress required checks for branch protection #12970. I thought by committing via github the signing requirements would be met, however it appears this setting requires all commits on a branch to be signed before the branch is mergeable.

TEST PLAN

  • PRs with unsigned commits will be mergeable after this PR merges

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai merged commit d2b0362 into apache:master Feb 9, 2021
@nytai nytai deleted the tai/fix-signing-req branch February 9, 2021 18:32
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Feb 10, 2021
Merge branch 'master' into decouple_filter_config_params
7891786 
* master:
  fix: UI toast typo (apache#13026)
  feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602)
  fix(build): black failing on master, add to required checks (apache#13039)
  fix: time filter db migration optimization (apache#13015)
  fix: untranslated text content of Dashboard page (apache#13024)
  fix(ci): remove signature requirements for commits to master (apache#13034)
  fix: add alerts and report to default config (apache#12999)
  docs(changelog): add entries for 1.0.1 (apache#12981)
  ci: skip cypress if no code changes (apache#12982)
  chore: add cypress required checks for branch protection (apache#12970)
  Refresh dashboard list after bulk delete (apache#12945)
  Updates storybook to version 6.1.17 (apache#13014)
  feat: Save datapanel state in local storage (apache#12996)
  fix: added text and changed margins (apache#12923)
  chore: Swap Slack Url 2 more places (apache#13004)
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
@nytai
fix(ci): remove signature requirements for commits to master (apache#…
bffcc8e 
…13034)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@nytai
fix(ci): remove signature requirements for commits to master (apache#…
3e1d1cf 
…13034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktmud ktmud ktmud approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nytai @ktmud @dpgaspar @mistercrunch