Skip to content

feat(native-filters): add storybook entry for select filter#13005

Merged
villebro merged 8 commits into
apache:masterfrom
simcha90:sync-native-filters-ui
Feb 13, 2021
Merged

feat(native-filters): add storybook entry for select filter#13005
villebro merged 8 commits into
apache:masterfrom
simcha90:sync-native-filters-ui

Conversation

@simcha90
Copy link
Copy Markdown
Contributor

@simcha90 simcha90 commented Feb 8, 2021

SUMMARY

Migrate storybook entry for Select Filter superset-ui.

SCREENSHOT

image

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Feb 8, 2021
@pull-request-size pull-request-size Bot added size/L and removed size/S labels Feb 10, 2021
@simcha90 simcha90 changed the title WIP: refactor(native-filters): update native filters ignores refactor(native-filters): update native filters ignores Feb 10, 2021
…filters-ui

� Conflicts:
�	superset-frontend/package-lock.json
�	superset-frontend/package.json
�	superset-frontend/src/explore/components/controls/VizTypeControl.jsx
�	superset-frontend/src/filters/components/Range/AntdRangeFilter.tsx
�	superset-frontend/src/filters/components/Range/index.ts
�	superset-frontend/src/filters/components/Select/index.ts
@villebro villebro changed the title refactor(native-filters): update native filters ignores feat(native-filters): add story book for filters Feb 13, 2021
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #13005 (b6d8d98) into master (2ce7982) will increase coverage by 8.63%.
The diff coverage is 10.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13005      +/-   ##
==========================================
+ Coverage   53.06%   61.69%   +8.63%     
==========================================
  Files         489      553      +64     
  Lines       17314    20254    +2940     
  Branches     4482     5300     +818     
==========================================
+ Hits         9187    12495    +3308     
+ Misses       8127     7546     -581     
- Partials        0      213     +213     
Flag Coverage Δ
cypress ?
javascript 61.69% <10.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <ø> (+11.50%) ⬆️
...perset-frontend/src/common/components/Dropdown.tsx 54.76% <ø> (+4.76%) ⬆️
...ontend/src/components/ListViewCard/ImageLoader.tsx 86.36% <0.00%> (+11.36%) ⬆️
...tiveFilters/FilterConfigModal/FilterConfigForm.tsx 70.37% <ø> (-6.99%) ⬇️
...src/explore/components/controls/VizTypeControl.jsx 78.46% <0.00%> (-12.45%) ⬇️
...d/src/filters/components/Range/AntdRangeFilter.tsx 0.00% <0.00%> (ø)
...set-frontend/src/filters/components/Range/index.ts 0.00% <0.00%> (-75.00%) ⬇️
...ers/components/Select/AntdSelectFilter.stories.tsx 0.00% <0.00%> (ø)
...src/filters/components/Select/AntdSelectFilter.tsx 0.00% <ø> (-96.78%) ⬇️
...et-frontend/src/filters/components/Select/index.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 484 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c4fac...b6d8d98. Read the comment docs.

@villebro villebro changed the title feat(native-filters): add story book for filters feat(native-filters): add storybook entry for select filter Feb 13, 2021
Copy link
Copy Markdown
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit dae1258 into apache:master Feb 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
…3005)

* refactor: update native filters ignores

* refactor: use behaviour variable

* refactor: move story for Filter select

* chore: update dependencies

* lint: fix lint

* remove unnecessary changes

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
* master: (30 commits)
  refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021)
  fix(native-filters): set currentValue null when empty (apache#13000)
  Custom superset_config.py + secret envs (apache#13096)
  Update http error code from 400 to 403 (apache#13061)
  feat(native-filters): add storybook entry for select filter (apache#13005)
  feat(native-filters): Time native filter (apache#12992)
  Force pod restart on config changes (apache#13056)
  feat(cross-filters): add cross filters (apache#12662)
  fix(explore): Enable selecting an option not included in suggestions (apache#13029)
  Improves RTL configuration (apache#13079)
  Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083)
  chore: lock down npm to v6 (apache#13069)
  fix: API tests, make them possible to run independently again (apache#13076)
  fix: add config to disable dataset ownership on the old api (apache#13051)
  add required * indicator to message content/notif method (apache#12931)
  fix: Retroactively add granularity param to charts (apache#12960)
  fix(ci): multiline regex in change detection (apache#13075)
  feat(style): hide dashboard header by url parameter (apache#12918)
  fix(explore): pie chart label bugs (apache#13052)
  fix: Disabled state button transition time (apache#13008)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…3005)

* refactor: update native filters ignores

* refactor: use behaviour variable

* refactor: move story for Filter select

* chore: update dependencies

* lint: fix lint

* remove unnecessary changes

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/L 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants