Skip to content

fix: API tests, make them possible to run independently again#13076

Merged
dpgaspar merged 2 commits into
apache:masterfrom
preset-io:fix/test-fixtures
Feb 11, 2021
Merged

fix: API tests, make them possible to run independently again#13076
dpgaspar merged 2 commits into
apache:masterfrom
preset-io:fix/test-fixtures

Conversation

@dpgaspar
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar commented Feb 11, 2021

SUMMARY

Quick fix to make it possible again to run API tests independently

Tested with:

./scripts/tests/run.sh --module tests/annotation_layers/api_tests.py

./scripts/tests/run.sh --module tests/charts/api_tests.py

./scripts/tests/run.sh --module tests/css_templates/api_tests.py

./scripts/tests/run.sh --module tests/dashboards/api_tests.py

./scripts/tests/run.sh --module tests/databases/api_tests.py

./scripts/tests/run.sh --module tests/reports/api_tests.py

Unfortunately datasets tests still depend on uncleaned data from other tests (difficult to pin), I'll address this problem on a separate PR

TEST PLAN

Run API tests independently

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title fix: API tests, possible to run independently fix: API tests, make them possible to run independently agina Feb 11, 2021
@dpgaspar dpgaspar changed the title fix: API tests, make them possible to run independently agina fix: API tests, make them possible to run independently again Feb 11, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 11, 2021

Codecov Report

Merging #13076 (8b0ad73) into master (2ce7982) will increase coverage by 13.82%.
The diff coverage is 34.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13076       +/-   ##
===========================================
+ Coverage   53.06%   66.88%   +13.82%     
===========================================
  Files         489      490        +1     
  Lines       17314    28856    +11542     
  Branches     4482        0     -4482     
===========================================
+ Hits         9187    19301    +10114     
- Misses       8127     9555     +1428     
Flag Coverage Δ
cypress ?
python 66.88% <34.23%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.64% <ø> (ø)
superset/examples/birth_names.py 73.19% <ø> (ø)
...s/260bf0649a77_migrate_x_dateunit_in_time_range.py 0.00% <0.00%> (ø)
...ons/versions/41ce8799acc3_rename_pie_label_type.py 0.00% <0.00%> (ø)
superset/utils/core.py 87.63% <47.36%> (ø)
superset/charts/commands/exceptions.py 92.85% <77.77%> (ø)
superset/db_engine_specs/elasticsearch.py 89.74% <93.75%> (ø)
superset/connectors/sqla/models.py 84.55% <100.00%> (ø)
superset/utils/date_parser.py 96.87% <100.00%> (ø)
...t-frontend/src/explore/actions/saveModalActions.js
... and 963 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c4fac...60d339a. Read the comment docs.

@dpgaspar dpgaspar merged commit fa4c118 into apache:master Feb 11, 2021
@dpgaspar dpgaspar deleted the fix/test-fixtures branch February 11, 2021 18:19
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
…#13076)

* fix: API tests, possible to run independently

* fix workflow name
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
* master: (30 commits)
  refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021)
  fix(native-filters): set currentValue null when empty (apache#13000)
  Custom superset_config.py + secret envs (apache#13096)
  Update http error code from 400 to 403 (apache#13061)
  feat(native-filters): add storybook entry for select filter (apache#13005)
  feat(native-filters): Time native filter (apache#12992)
  Force pod restart on config changes (apache#13056)
  feat(cross-filters): add cross filters (apache#12662)
  fix(explore): Enable selecting an option not included in suggestions (apache#13029)
  Improves RTL configuration (apache#13079)
  Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083)
  chore: lock down npm to v6 (apache#13069)
  fix: API tests, make them possible to run independently again (apache#13076)
  fix: add config to disable dataset ownership on the old api (apache#13051)
  add required * indicator to message content/notif method (apache#12931)
  fix: Retroactively add granularity param to charts (apache#12960)
  fix(ci): multiline regex in change detection (apache#13075)
  feat(style): hide dashboard header by url parameter (apache#12918)
  fix(explore): pie chart label bugs (apache#13052)
  fix: Disabled state button transition time (apache#13008)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…#13076)

* fix: API tests, possible to run independently

* fix workflow name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants