Skip to content

feat: Force pod restart on config changes#13056

Merged
craig-rueda merged 1 commit into
apache:masterfrom
Yann-J:master
Feb 13, 2021
Merged

feat: Force pod restart on config changes#13056
craig-rueda merged 1 commit into
apache:masterfrom
Yann-J:master

Conversation

@Yann-J
Copy link
Copy Markdown
Contributor

@Yann-J Yann-J commented Feb 10, 2021

SUMMARY

Added some checksum annotations in the chart template to trigger a pod restart if any dependent configuration has changed (therefore not needing the forceReload flag)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • Deploy an existing release with the updated chart (helm upgrade --install --values my-values.yaml superset helm/superset)
  • Change some config value in my-values.yaml (e.g. adding an additionalRequirements)
  • Upgrade the release with the same command
  • Check that a new Deployment/ReplicaSet/Pod have been spawned

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@Yann-J Yann-J changed the title Force pod restart on config changes feat: Force pod restart on config changes Feb 12, 2021
Copy link
Copy Markdown
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking for that, thank you!

@craig-rueda craig-rueda merged commit acca3a4 into apache:master Feb 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Feb 14, 2021
* master: (30 commits)
  refactor(native-filters): decouple params from filter config modal (first phase) (apache#13021)
  fix(native-filters): set currentValue null when empty (apache#13000)
  Custom superset_config.py + secret envs (apache#13096)
  Update http error code from 400 to 403 (apache#13061)
  feat(native-filters): add storybook entry for select filter (apache#13005)
  feat(native-filters): Time native filter (apache#12992)
  Force pod restart on config changes (apache#13056)
  feat(cross-filters): add cross filters (apache#12662)
  fix(explore): Enable selecting an option not included in suggestions (apache#13029)
  Improves RTL configuration (apache#13079)
  Added a note about the ! prefix for breaking changes to CONTRIBUTING.md (apache#13083)
  chore: lock down npm to v6 (apache#13069)
  fix: API tests, make them possible to run independently again (apache#13076)
  fix: add config to disable dataset ownership on the old api (apache#13051)
  add required * indicator to message content/notif method (apache#12931)
  fix: Retroactively add granularity param to charts (apache#12960)
  fix(ci): multiline regex in change detection (apache#13075)
  feat(style): hide dashboard header by url parameter (apache#12918)
  fix(explore): pie chart label bugs (apache#13052)
  fix: Disabled state button transition time (apache#13008)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants