feat: Adding FORCE_SSL as feature flag in config.py#14934
Merged
Conversation
AAfghahi
force-pushed
the
ch15953_showSSLToggle
branch
from
2b445f3 to
9494edf
Compare
hughhhh
approved these changes
Jun 1, 2021
Codecov Report
@@ Coverage Diff @@
## master #14934 +/- ##
==========================================
- Coverage 77.62% 77.39% -0.24%
==========================================
Files 963 963
Lines 49316 49334 +18
Branches 6228 6228
==========================================
- Hits 38284 38180 -104
- Misses 10833 10955 +122
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
reviewed
Jun 1, 2021
| # for report with type 'report' still send with email and slack message with | ||
| # screenshot and link | ||
| "ALERTS_ATTACH_REPORTS": True, | ||
| "FORCE_SSL": False, |
Member
There was a problem hiding this comment.
Can you add documentation about what this flag does?
Member
Author
There was a problem hiding this comment.
Yeah! where should I add the documentation?
Member
There was a problem hiding this comment.
inline, similarly to the other feature flags would be great, thanks!
AAfghahi
force-pushed
the
ch15953_showSSLToggle
branch
from
eb7d011 to
9d0aeee
Compare
etr2460
approved these changes
Jun 2, 2021
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
Thanks for the documentation! I think naming this FORCE_DATABASE_CONNECTIONS_SSL might be clearer since FORCE_SSL might imply that connecting to the webserver is forced with SSL, but up to you
AAfghahi
force-pushed
the
ch15953_showSSLToggle
branch
from
9d0aeee to
42ccdc7
Compare
Member
Author
I like that, I am going to change it here and also in superset-ui |
hughhhh
reviewed
Jun 2, 2021
AAfghahi
force-pushed
the
ch15953_showSSLToggle
branch
from
643a92b to
af6014b
Compare
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
AAfghahi
force-pushed
the
ch15953_showSSLToggle
branch
from
af6014b to
6f17e95
Compare
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jun 6, 2021
* upstream/master: (68 commits) fix typos (apache#14950) docs: fix custom oauth config (apache#14997) fix: apply template_params on external_metadata (apache#14996) fix: toggle fullscreen on the dashboard (apache#14979) feat(native-filters): add markers and number formatter + simple tests (apache#14981) fix(native-filters): Fix "undefined" error after editing a filter (apache#14984) fix(native-filters): remove implied fetch predicate (apache#14982) fix(native-filters): update cascaded filter state on change (apache#14980) fix(filter box): replace freeform where clause with ilike (apache#14900) refactor: Convert TableElement.jsx component from class to functional with hooks (apache#14830) fix: renamed sqllab filters to _filters (apache#14971) feat(native-filters): apply cascading without instant filtering (apache#14966) chore: bump superset-ui to 0.17.53 (apache#14968) fix(native-filters): cascading filters not rendering in tab (apache#14964) feat: add type_generic and is_dttm to table metadata (apache#14863) additional safeguard (apache#14953) feat: Adding FORCE_SSL as feature flag in config.py (apache#14934) feat(dashboard/native-filters): Hide filters out of scope of current tab (apache#14933) fix: time parser truncate to first day of year/month (apache#14945) fix: is_temporal should overwrite is_dttm (apache#14894) ...
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a feature flag for the new dynamic form being used for creating and editing databases.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
go to config.py and look for FORCE_SSL
ADDITIONAL INFORMATION