fix(native-filters): Fix "undefined" error after editing a filter

[kgabryje]

SUMMARY

We calculate chartsInScope and tabsInScope of native filters on first render and recalculate them only when filter's scope or dashboard's layout changes. When user edited a filter without changing it's scope, chartsInScope and tabsInScope were being set to undefined, which was causing an caused an error described in #14975.
This PR fixes it by merging edited filter into the old filter rather than overriding it. Since the edited filter object has exactly the same fields as the old filter except chartsInScope and tabsInScope, what really happens is that we override the old filter and add chartsInScope and tabsInScope fields.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: See linked issue
After:
https://user-images.githubusercontent.com/15073128/120797636-97c65800-c53c-11eb-96ac-8c34f35bb801.mov

TESTING INSTRUCTIONS

0. Enable DASHBOARD_NATIVE_FILTERS feature flag
1. Add a native filter
2. Click on the filter and verify that tabs and charts in scope get highlighted
3. Edit the filter without changing it's scope
4. Verify that charts and tabs still get highlighted when you focus on the filter

ADDITIONAL INFORMATION

• Has associated issue: closes [native-filters]Apply changes instantly in time-grain filter crashes page #14975
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

CC: @junlincc @villebro

[codecov]

Codecov Report

Merging #14984 (9884e86) into master (61a438a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 9884e86 differs from pull request most recent head ef2f0e2. Consider uploading reports for the commit ef2f0e2 to get more accurate results

@@            Coverage Diff             @@
##           master   #14984      +/-   ##
==========================================
+ Coverage   77.53%   77.62%   +0.08%     
==========================================
  Files         965      965              
  Lines       49504    49509       +5     
  Branches     6259     6260       +1     
==========================================
+ Hits        38384    38430      +46     
+ Misses      10920    10879      -41     
  Partials      200      200              

Flag	Coverage Δ
javascript	72.49% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rontend/src/filters/components/Range/buildQuery.ts	40.00% <ø> (ø)
...ontend/src/filters/components/Select/buildQuery.ts	100.00% <ø> (ø)
...et-frontend/src/dashboard/actions/nativeFilters.ts	82.69% <100.00%> (+1.84%)	⬆️
superset/models/core.py	90.00% <0.00%> (+0.26%)	⬆️
superset/connectors/sqla/models.py	89.81% <0.00%> (+1.42%)	⬆️
superset/db_engine_specs/presto.py	90.31% <0.00%> (+5.89%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a438a...ef2f0e2. Read the comment docs.

[villebro]

Makes sense; LGTM + tested to work, thanks for the quick fix!