feat(native-filters): apply cascading without instant filtering

[villebro]

SUMMARY

Currently enabling cascading in native filters requires instantly applying filters, causing all charts in scope to rerender and retrigger queries. This PR changes child filters to apply the currently selected data mask of the parent filter instead of the currently applied one, removing the need to instantly apply filters.

While making the changes, I considered moving dataMaskSelected into Redux instead of adding it as a prop on the chain of components. However, I noticed that many of the intermediate components between the filter tab and FilterValue were already using dataMaskSelected, which made the benefits of moving it to Redux less appealing. In addition, adding it to Redux would have required either

• introducing a new dataMaskSelected property to complement the dataMask property (which contains the applied data mask) in the state tree

or

• refactoring dataMask so that it would be split into dataMask.applied and dataMask.selected

Since both of these would have required fairly significant refactoring, it seems better to perform this refactoring later when the full scope of refactoring needs is clear (e.g. will some of this state be moved into Context or be kept in Redux).

BFEORE

Currently each time a parent filter is changed, it triggers the filter automatically:
https://user-images.githubusercontent.com/33317356/120623645-962b6000-c468-11eb-86b5-db95319691f4.mp4

AFTER

Now the parent filter only retriggers the child filters (applying works like before):
https://user-images.githubusercontent.com/33317356/120628894-e2c56a00-c46d-11eb-8200-51d2c73ea10d.mp4

TESTING INSTRUCTIONS

1. Create a dashboard with cascading filters
2. Make sure the parent filter is not set to "Apply changes instantly"
3. Change the selection in the parent filter

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14966 (bf656b5) into master (f94c6d2) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

❗ Current head bf656b5 differs from pull request most recent head 1ee5360. Consider uploading reports for the commit 1ee5360 to get more accurate results

@@            Coverage Diff             @@
##           master   #14966      +/-   ##
==========================================
- Coverage   77.62%   77.62%   -0.01%     
==========================================
  Files         965      965              
  Lines       49521    49510      -11     
  Branches     6263     6259       -4     
==========================================
- Hits        38442    38430      -12     
- Misses      10878    10880       +2     
+ Partials      201      200       -1     

Flag	Coverage Δ
javascript	72.48% <70.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rBar/CascadeFilters/CascadeFilterControl/index.tsx	92.30% <ø> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx	100.00% <ø> (ø)
...ilters/FilterBar/FilterControls/FilterControls.tsx	77.58% <ø> (ø)
...ts/nativeFilters/FilterBar/FilterControls/state.ts	78.57% <40.00%> (-1.43%)	⬇️
.../FilterBar/CascadeFilters/CascadePopover/index.tsx	63.23% <100.00%> (-1.56%)	⬇️
...veFilters/FilterBar/FilterControls/FilterValue.tsx	67.44% <100.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx	100.00% <100.00%> (ø)
superset-frontend/src/dataMask/actions.ts	71.42% <0.00%> (-7.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94c6d2...1ee5360. Read the comment docs.

[villebro]

Bycatch: incorrect datatype

[michael-s-molina]

Two issues:
1 - If I select a parent filter then it filters the child filters. However, if I select the child filters first, and select the parent filter after, the values are inconsistent as shown in the video. Is this a problem?
2 - There's an error happening when trying to access the filter after updating the filters. This error is not happening on master.

20210603085803494_OpHTRWqp.mov

[zhaoyongjie]

can't remove selected item

can.t.remove.selected.item.mp4

[villebro]

can't remove selected item

Thanks for flagging this! It seems to be happening on master, too, so isn't directly related to this change.

[villebro]

Two issues:
1 - If I select a parent filter then it filters the child filters. However, if I select the child filters first, and select the parent filter after, the values are inconsistent as shown in the video. Is this a problem?
2 - There's an error happening when trying to access the filter after updating the filters. This error is not happening on master.

1. I don't think this is a problem, as the value filter supports creating values that don't exist in the query result. But we can potentially consider resetting child values that aren't present when updating the parent. Let's discuss this later.
2. I was able to reproduce this problem on master. Therefore I propose merging this now and following up with a fix for this bug and the bug @zhaoyongjie pointed out (also present on master)