Skip to content

perf: Optimize dashboard chart-related components#31241

Merged
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:perf/optimize-chart-components
Dec 2, 2024
Merged

perf: Optimize dashboard chart-related components#31241
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:perf/optimize-chart-components

Conversation

@kgabryje
Copy link
Copy Markdown
Member

@kgabryje kgabryje commented Dec 2, 2024

SUMMARY

This PR supersedes #30958.
Related to PRs: #31240, #31242, #31243, #31244.

Optimizes gridComponents/Chart.jsx and ChartHolder.tsx components - converted Chart.jsx to function component, memoized props passed to children, optimized Redux selectors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

For detailed perf improvement results, see the details in PR #30958

TESTING INSTRUCTIONS

No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend dashboard:performance Related to Dashboard performance size/XXL 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants