perf: Optimize native filters and cross filters#31243
Merged
Merged
Conversation
dosubot
Bot
added
dashboard:cross-filters
This was referenced Dec 2, 2024
geido
approved these changes
Dec 2, 2024
kgabryje
force-pushed
the
perf/optimize-native-filters
branch
from
a9de786 to
02b7e50
Compare
9 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR supersedes #30958.
Related to PRs: #31240, #31241, #31242, #31244.
Optimizes utils and components related to native filters and cross filters. Many util functions, such as
useSelectChartTabParentsorgetCrossFilterIndicatorwere suboptimal, running some operations unnecessarily, and were being called from components redundantly. This PR implements memoization in filter bar components, improves Redux selectors and optimizes the util functions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
For detailed perf improvement results, see the details in PR #30958
TESTING INSTRUCTIONS
No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before
ADDITIONAL INFORMATION