Skip to content

perf: Optimize Dashboard components#31242

Merged
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:perf/optimize-dashboard-components
Dec 2, 2024
Merged

perf: Optimize Dashboard components#31242
kgabryje merged 1 commit into
apache:masterfrom
kgabryje:perf/optimize-dashboard-components

Conversation

@kgabryje
Copy link
Copy Markdown
Member

@kgabryje kgabryje commented Dec 2, 2024 •
edited
Loading

SUMMARY

This PR supersedes #30958.
Related to PRs: #31240, #31241, #31243, #31244.

Optimizes dashboard components such as DashboardBuilder, DashboardComponent, DashboardContainer - memoized props passed to children, improve Redux selectors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

For detailed perf improvement results, see the details in PR #30958

TESTING INSTRUCTIONS

No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje requested a review from geido December 2, 2024 13:08
@dosubot dosubot Bot added the dashboard:performance Related to Dashboard performance label Dec 2, 2024
This was referenced Dec 2, 2024
Merged
Merged
Merged
Merged
@kgabryje kgabryje merged commit 24d001e into apache:master Dec 2, 2024
@kgabryje kgabryje mentioned this pull request Dec 2, 2024
Closed
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@kgabryje
perf: Optimize Dashboard components (apache#31242)
066a10e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:performance Related to Dashboard performance size/L 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kgabryje @geido @mistercrunch