Fix use of Error as name for error enum in UDL#214
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Oct 21, 2022
Merged
Fix use of Error as name for error enum in UDL#214thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
fix-error
branch
from
230c16d to
c7d0803
Compare
6 tasks
notmandatory
added a commit
that referenced
this pull request
Oct 27, 2022
ee6ee81 Add simple kotlin,swift, and python integration tests (Steve Myers) Pull request description: ### Description Add simple kotlin, swift and python integration tests. These tests confirm fixes in #216 and #214. ### Notes to the reviewers To skip integration tests use: `cargo test --lib`. Otherwise java, kotlin, swift, and python need to be installed, and you must run tests with: `CLASSPATH=./tests/jna/jna-5.8.0.jar cargo test` ### Changelog notice - Integration tests added, see tests/README.md for updated instructions for running tests. #215 ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [x] I've added docs for the new feature #### Bugfixes: * [x] I've added tests to reproduce the issue which are now passing ACKs for top commit: thunderbiscuit: ACK [ee6ee81](ee6ee81). waterst0ne: > ACK [ee6ee81](ee6ee81). Tree-SHA512: 06ab14da1185de431c16b767f187bc8e7792106df54314242b26f225e3a8ddada28317b7cb8bec47b8b248d3088d0305ab777770525540c72d2815349a73728b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the name of the error enum in the UDL from
ErrortoBdkError.The issue is described in mozilla/uniffi-rs#1020.
Fixes #213.
Changelog notice
No changelog notice, since this is reverting back to our old API. (it simply cleaned up the internals of the Rust code).
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: