Skip to content

Update uniffi dependencies to 0.21.0#216

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:update_uniffi_021
Oct 21, 2022
Merged

Update uniffi dependencies to 0.21.0#216
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:update_uniffi_021

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Oct 21, 2022

Description

Update uniffi dependencies to 0.21.0

Notes to the reviewers

This is required to pickup my PR to handle swift keywords. mozilla/uniffi-rs@v0.20.0...v0.21.0

Changelog notice

Update uniffi-rs to latest version 0.20.0 #216

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added the bug Something isn't working label Oct 21, 2022
@notmandatory notmandatory added this to the Release 0.10.0 milestone Oct 21, 2022
@notmandatory notmandatory self-assigned this Oct 21, 2022
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b9aa0a2.

@notmandatory notmandatory merged commit 3bec5d2 into bitcoindevkit:master Oct 21, 2022
notmandatory added a commit that referenced this pull request Oct 27, 2022
ee6ee81 Add simple kotlin,swift, and python integration tests (Steve Myers)

Pull request description:

  ### Description

  Add simple kotlin, swift and python integration tests. These tests confirm fixes in #216 and #214.

  ### Notes to the reviewers

  To skip integration tests use:

  `cargo test --lib`.

  Otherwise java, kotlin, swift, and python need to be installed, and you must run tests with:

  `CLASSPATH=./tests/jna/jna-5.8.0.jar cargo test`

  ### Changelog notice

  - Integration tests added, see tests/README.md for updated instructions for running tests. #215

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing

ACKs for top commit:
  thunderbiscuit:
    ACK [ee6ee81](ee6ee81).
  waterst0ne:
    > ACK [ee6ee81](ee6ee81).

Tree-SHA512: 06ab14da1185de431c16b767f187bc8e7792106df54314242b26f225e3a8ddada28317b7cb8bec47b8b248d3088d0305ab777770525540c72d2815349a73728b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants