Add simple kotlin, swift and python integration tests#215
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Oct 27, 2022
Merged
Add simple kotlin, swift and python integration tests#215notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
notmandatory
force-pushed
the
add_test_fixtures
branch
7 times, most recently
from
439d502 to
96d5c15
Compare
notmandatory
force-pushed
the
add_test_fixtures
branch
from
96d5c15 to
ee6ee81
Compare
notmandatory
changed the title
Contributor
|
Hi @notmandatory This a link to the full log error on a hackmd . |
Member
|
@waterst0ne from your log in the link I think you're calling the tests with a classpath that has a typo: you're using CLASSPATH=./test/jna/...instead of CLASSPATH=./tests/jna/Let me know if that fixes it. |
Member
|
The Kotlin and Python tests work for me, and I assume the Swift ones would as well but I'm running into a Rosetta/M1 issue. Here is my error: ld: warning: ignoring file /Users/user0/repos/bdk-ffi/target/debug/libbdkffi.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64I've had problems with this before where the terminal is using Rosetta so it thinks it's in an x86_64 but then you compile something and that does its work on the arm64 architecture and you get these errors. It's clear it's one of those, but I'm not sure how to get it to work. In any case I can comment out the Swift test and it runs fine, and since the primary purpose of this is to run in the CI, I think it should be fine. Example of problem outlined here. Using two toolchains at once unknowingly (homebrew and xcode). |
Contributor
That seemed to fix it and pass the integration tests but generated some warnings on two machines. The warnings are |
Member
|
Yeah I think those are simply the Swift compiler warnings to help clarify that the backticks are not required. But uniffi-rs puts them there for all languages I think, so that you don't have any surprises. ACK ee6ee81. |
thunderbiscuit
approved these changes
Oct 26, 2022
Member
Author
|
Yes those swift warnings are expected and unfortunately no way to disable certain warnings in swift. Also I get the same swift error with the M1 macOS .. but works with x86 macOS or Linux (which is what CI is using). |
Contributor
Ack #ee6ee8139afd74c858216ed99ffdec92dc101787
ACK ee6ee81. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add simple kotlin, swift and python integration tests. These tests confirm fixes in #216 and #214.
Notes to the reviewers
To skip integration tests use:
cargo test --lib.Otherwise java, kotlin, swift, and python need to be installed, and you must run tests with:
CLASSPATH=./tests/jna/jna-5.8.0.jar cargo testChangelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: