chore: Minor changes in providers envs logic#161
Merged
elenazherdeva merged 3 commits intomainfrom Oct 28, 2024
Merged
Conversation
Contributor
elenazherdeva
commented
Oct 17, 2024
elenazherdeva
commented
- change in logic for MissingProviderEnvVariableError
- non-empty check for PROVIDER_NAME
lamchau
approved these changes
Oct 17, 2024
Contributor
There was a problem hiding this comment.
awesome! thanks for getting this out so quickly! lgtm (one failing test)
cc: @codefromthecrypt, this should help with your pr!
lamchau
reviewed
Oct 17, 2024
|
|
||
| if missing_vars: | ||
| env_vars = ", ".join(missing_vars) | ||
| raise MissingProviderEnvVariableError(env_vars, cls.PROVIDER_NAME, instructions_url) |
Contributor
There was a problem hiding this comment.
:nit: maybe we add a test for 2 env vars?
lamchau
force-pushed
the
ez/providers_bug
branch
5 times, most recently
from
4134ee6 to
2beca8e
Compare
lamchau
force-pushed
the
ez/providers_bug
branch
from
2beca8e to
1b7668f
Compare
lifeizhou-ap
approved these changes
Oct 28, 2024
Contributor
Author
|
thank you for the fix @lamchau! |
lifeizhou-ap
added a commit
that referenced
this pull request
Oct 30, 2024
* main: chore: housekeeping (#202) feat: reduce tool entrypoints in synopsis for text editor, bash, process manager (#191) feat: list moderators (#204) chore: Minor changes in providers envs logic (#161) chore: add `.vscode` workspace settings and suggested extensions (#200) feat: license checker (#201) feat: include new anthropic model in docs and recommended config (#198) feat: tiny change so you know what processing is doing (#196) docs: correct intellij link (#197) docs: remove small duplication (#194) chore: add tracing option to run and group traces under session name (#187) docs: fix mkdocs, update to new references (#193)
ahau-square
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Lam Chau <lam@tbd.email>
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
Co-authored-by: Lam Chau <lam@tbd.email>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Co-authored-by: Lam Chau <lam@tbd.email>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.