Skip to content

Comments

chore: housekeeping#202

Merged
lamchau merged 6 commits intoblock:mainfrom
lamchau:lam/housekeeping
Oct 29, 2024
Merged

chore: housekeeping#202
lamchau merged 6 commits intoblock:mainfrom
lamchau:lam/housekeeping

Conversation

@lamchau
Copy link
Contributor

@lamchau lamchau commented Oct 28, 2024

  • added macOS specific .gitignores
  • sorted recipes since just --list is a little longer now it's easier to read
  • not sure why i wanted to ignore running the workflow tests, so removed that to run all the time

@lamchau lamchau added the ready label Oct 28, 2024
justfile Outdated
if ! git diff --quiet pyproject.toml; then
uv run pytest .github/workflows {{ FLAGS }}
fi
@uv run pytest .github/workflows tests -m "not integration" {{ FLAGS }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this skipping the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean the @ prefix?

the varargs just runs it on 2 folders instead of 1 now (we do skip exchange tests, but that was always the case). it didn't make any sense why i'd only run unit tests if the project toml changed

$ just test
========= 197 passed in 6.78s ==========

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok - I thought removing uv run pytest tests -m "not integration" {{ FLAGS }} means it would only run workflow tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah i see, there's 2 folders there that isn't super obvious. added trailing slashes for clarity if that makes more sense 3309b70

get-tag-version:
#!/usr/bin/env bash
uvx --from=toml-cli toml get --toml-path=pyproject.toml "project.version"
@uvx --from=toml-cli toml get --toml-path=pyproject.toml "project.version"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does '@' do in a justfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just suppresses the command to stdout

with @

hello:
  @echo "hello world"
hello world

without

hello:
  echo "hello world"
echo "hello world!"
hello world

@lamchau lamchau merged commit 7285cbb into block:main Oct 29, 2024
@lamchau lamchau deleted the lam/housekeeping branch October 29, 2024 23:00
lifeizhou-ap added a commit that referenced this pull request Oct 30, 2024
* main:
  chore: housekeeping (#202)
  feat: reduce tool entrypoints in synopsis for text editor, bash, process manager (#191)
  feat: list moderators (#204)
  chore: Minor changes in providers envs logic (#161)
  chore: add `.vscode` workspace settings and suggested extensions (#200)
  feat: license checker (#201)
  feat: include new anthropic model in docs and recommended config (#198)
  feat: tiny change so you know what processing is doing (#196)
  docs: correct intellij link (#197)
  docs: remove small duplication (#194)
  chore: add tracing option to run and group traces under session name (#187)
  docs: fix mkdocs, update to new references (#193)
ahau-square pushed a commit that referenced this pull request Nov 6, 2024
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants