Merged
Conversation
lamchau
requested review from
ahau-square,
baxen,
elenazherdeva,
michaelneale,
salman1993 and
zakiali
lamchau
force-pushed
the
lam/license-checker-v2
branch
from
54dfd88 to
d965977
Compare
zakiali
reviewed
Oct 25, 2024
| Returns: | ||
| str | None: The license of the package, or None if not found. | ||
| """ | ||
| if package_name in self.config.exceptions: |
Collaborator
There was a problem hiding this comment.
this line seems redundant with the check in check_packages?
Contributor
Author
There was a problem hiding this comment.
ohh v good catch! i was being overly defensive during refactoring. deleted in 48ee1ce
michaelneale
approved these changes
Oct 26, 2024
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
nice improvements!
lifeizhou-ap
added a commit
that referenced
this pull request
Oct 30, 2024
* main: chore: housekeeping (#202) feat: reduce tool entrypoints in synopsis for text editor, bash, process manager (#191) feat: list moderators (#204) chore: Minor changes in providers envs logic (#161) chore: add `.vscode` workspace settings and suggested extensions (#200) feat: license checker (#201) feat: include new anthropic model in docs and recommended config (#198) feat: tiny change so you know what processing is doing (#196) docs: correct intellij link (#197) docs: remove small duplication (#194) chore: add tracing option to run and group traces under session name (#187) docs: fix mkdocs, update to new references (#193)
ahau-square
pushed a commit
that referenced
this pull request
Nov 6, 2024
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just formattriggeredrufferrors so normalized. ended up adding some quality of life for maintenance and possibly we can consider OSS as an actionchanges
Output
Tests