Skip to content

test: CLI command test coverage for 8 untested commands + wiring regression#246

Closed
bradygaster wants to merge 8 commits intodevfrom
squad/hockney-cli-test-coverage
Closed

test: CLI command test coverage for 8 untested commands + wiring regression#246
bradygaster wants to merge 8 commits intodevfrom
squad/hockney-cli-test-coverage

Conversation

@bradygaster
Copy link
Copy Markdown
Owner

@bradygaster bradygaster commented Mar 7, 2026

What

Closes the 8-command test coverage gap identified in the quality assessment.

New tests (77 total across 9 files)

Command File Tests Coverage
link test/cli/link.test.ts 10 Validation, fs ops, gitignore, error paths
init-remote test/cli/init-remote.test.ts 8 Config structure, relative paths, idempotency
watch test/cli/watch.test.ts 6 Exports, reportBoard pure function
start test/cli/start.test.ts 3 Module exports, function arity
rc-tunnel test/cli/rc-tunnel.test.ts 10 Exports, getMachineId, getGitInfo, destroyTunnel safety
extract test/cli/extract.test.ts 5 Exports, error handling for missing/invalid config
copilot test/cli/copilot.test.ts 6 Exports, add/remove flow, error on missing squad dir
copilot-bridge test/cli/copilot-bridge.test.ts 8 Class instantiation, lifecycle, safe-before-init
wiring regression test/cli-command-wiring.test.ts 21 Every .ts in commands/ has route in cli-entry.ts

Also included

  • 6 new subpath exports in squad-cli package.json (watch, start, rc-tunnel, extract, copilot, copilot-bridge)
  • KNOWN_UNWIRED set documents watch.ts (stub) and upstream.ts (wired differently)
  • Decision written to .squad/decisions/inbox/

Test results

All 77 new tests pass. 3 pre-existing failures (human-journeys, speed-gates, acceptance/hostile) are unchanged.

Working as Hockney (Tester)

bradygaster and others added 8 commits March 6, 2026 21:00
@bradygaster
docs(ai-team): Phase 4 complete: 3 PRs merged, 8 issues closed, relea…
6e304ec 
…se wave done

Session: 2026-03-07T04-55-00Z-phase4-complete
Phase 4 Summary:
- Merged PR #235 (commit ce418c6): Test stabilization
- Merged PR #234 (commit f88bf4c): Runtime bug fixes
- Merged PR #233 (commit 2f42e32): CLI wiring + CI fix
- Closed 8 issues from PRs #234 and #233
- Test suite now at 100% pass rate (3,656 passing)
- CI fully green and stable
- Release wave v0.8.21 COMPLETE

Changes:
- Merged 4 decision inbox files into decisions.md
- Deleted 4 inbox files (now in shared decisions)
- 1 PR (#235) + 1 PR (#234) = 2 PRs already merged (Kobayashi phase 4)
- 1 PR (#233) rebased and merged by Coordinator
- All team state preserved via merge=union

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
docs(ai-team): Merge next-wave triage decisions, update agent history
a811571 
Session: 2026-03-07-next-wave-triage
Requested by: Brady

Changes:
- Merged 3 inbox decisions (Keaton triage, Fenster PR review, Hockney test health)
- Updated agent history files with cross-team context propagation
- Deleted TRIAGE_REPORT.md from repo root (triage data belongs in .squad/)
- Orchestration logs written for all 3 agents
- Session log created for triage fan-out results
- Decision deduplication verified (no exact duplicates)

Decisions merged:
- Keaton: Full 22-issue triage, P0-P3 prioritization, v0.8.22 plan (11 issues)
- Fenster: 4 PR review, all retarget to dev, CLI wiring pattern adopted
- Hockney: Test suite health, 8 CLI commands untested, 30+ error-handling tests needed

Cross-agent context:
- Fenster: Notified of test gaps for CLI wiring work
- Edie: Notified of model config priority (#223 > #205)
- Rabin: Notified of migration wave grouping (#197/#231/#126) and ADO config blocker
- Keaton: Updated with triage scope and decisions
- Hockney: Updated with test infrastructure gaps for next-wave

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
docs: update fenster history & add model-config decision
b562ef1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
test: add tests for 8 untested CLI commands + wiring regression test
38ec894 
Add test coverage for all 8 CLI commands that had zero tests:
- link (10 tests): validation, fs operations, gitignore handling
- init-remote (8 tests): config structure, relative paths, idempotency
- watch (6 tests): module exports, reportBoard pure function
- start (3 tests): module exports, function arity
- rc-tunnel (10 tests): exports, getMachineId, getGitInfo, devtunnel availability
- extract (5 tests): exports, error handling for missing/invalid config
- copilot (6 tests): exports, error on missing squad dir, add/remove flow
- copilot-bridge (8 tests): class instantiation, lifecycle, safe-before-init

Add command wiring regression test (21 tests) that verifies every .ts
file in commands/ has a corresponding route in cli-entry.ts, preventing
the recurring unwired command bug class (issues #224, #236, #237).

Add subpath exports to squad-cli package.json for the 6 commands that
were missing package exports (watch, start, rc-tunnel, extract, copilot,
copilot-bridge).

Total: 77 new tests, all passing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
docs(ai-team): Next-wave Fenster completions logged
46e1a84 
Session: 2026-03-07T14-16-00Z-next-wave-fenster-completions
Requested by: Scribe (autonomous)

Changes:
- Logged agent-32 completion: CLI command wiring (#237) — 4 commands wired, 3655 tests pass, PR #244
- Logged agent-31 completion: Model config reliability (#223) — root cause fixed, backwards compatible, PR #245
- Updated Fenster's history.md with cross-agent context about CLI wiring and model config patterns
@bradygaster
docs: update Hockney history and add CLI test coverage decision
6cee38b 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
docs(ai-team): Scribe tasks for Hockney CLI test coverage sprint
374b57a 
Session: 2026-03-07T14-17-00Z-next-wave-hockney-tests
Requested by: GitHub Copilot CLI

Changes:
- Logged orchestration for agent-33 (Hockney) CLI test coverage (77 new tests, 8 commands covered)
- Merged wiring regression test decision into decisions.md
- Recorded session log and orchestration log for team reference
- Updated Hockney's history.md with CLI command coverage completion

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
test: bump speed gate help line threshold to 80
510e6a9 
Matches the same fix applied to PR #245. New CLI commands added legitimate help text.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
Copy link
Copy Markdown
Owner Author

bradygaster commented Mar 7, 2026

Closing — all test code from this PR was included in the #245 squash merge and is already on dev. Only Scribe doc updates remained. The 77 new tests and wiring regression test are live. ✅

@bradygaster bradygaster closed this Mar 7, 2026
jongio pushed a commit to jongio/squad that referenced this pull request Mar 9, 2026
@bradygaster
docs: migration guide — GitHub-native to npm (bradygaster#218)
884861a 
* docs: migration guide — GitHub-native to npm (bradygaster#218)

Closes bradygaster#218

Adds docs/migration-github-to-npm.md for users migrating from GitHub-native distribution to npm packages (@bradygaster/squad-cli and @bradygaster/squad-sdk).

Changes:
- New migration guide with before/after examples, insider channel info, comparison table, and troubleshooting
- Updated README.md to reference migration guide in Legacy Distribution section

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: message routing + shell commands (bradygaster#245, bradygaster#246)

Add message router (src/cli/shell/router.ts):
- Slash command parsing (/status, /help, etc.)
- @agent direct addressing with case-insensitive matching
- AgentName, message comma syntax support
- Coordinator fallback for unmatched input

Add shell commands (src/cli/shell/commands.ts):
- /status — squad status and active agents
- /history — recent message history with limit
- /agents — list registered agents with status icons
- /clear — ANSI clear screen
- /help — command reference
- /quit, /exit — clean shutdown

Both modules exported from src/cli/shell/index.ts barrel.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio pushed a commit to jongio/squad that referenced this pull request Mar 9, 2026
@bradygaster
feat: message routing + shell commands (bradygaster#245, bradygaster#246
2341063 
)

Add message router (src/cli/shell/router.ts):
- Slash command parsing (/status, /help, etc.)
- @agent direct addressing with case-insensitive matching
- AgentName, message comma syntax support
- Coordinator fallback for unmatched input

Add shell commands (src/cli/shell/commands.ts):
- /status — squad status and active agents
- /history — recent message history with limit
- /agents — list registered agents with status icons
- /clear — ANSI clear screen
- /help — command reference
- /quit, /exit — clean shutdown

Both modules exported from src/cli/shell/index.ts barrel.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster bradygaster deleted the squad/hockney-cli-test-coverage branch March 16, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bradygaster