cranelift-jit: add bump memory allocator, make configurable#10512
Merged
alexcrichton merged 6 commits intobytecodealliance:mainfrom Apr 9, 2025
Merged
Conversation
bjorn3
reviewed
Apr 2, 2025
bjorn3
reviewed
Apr 2, 2025
github-actions
Bot
added
the
cranelift
This adds a new JIT memory allocator which operates on an address range that is reserved up-front. This is useful in order to side-step issues where allocation behavior affect relocations, i.e. on x86 where we run into issues when the system allocator returns memory that is more than 4 GiB apart. The main drawback of this allocator option is that the memory range has to be reserved up-front, so allocation will fail if this space is exhausted. This commit: - adds a 'JITMemoryProvider' trait - moves the previous on-demand allocator to this trait - adds a new 'Arena' allocator
Mrmaxmeier
force-pushed
the
cranelift-jit-pluggable-memory-provider
branch
from
f508348 to
0621d5b
Compare
abrown
approved these changes
Apr 4, 2025
Member
abrown
left a comment
abrown
left a comment
There was a problem hiding this comment.
I think this overall makes sense to me; I didn't look too, too closely at all the arithmetic so it would be useful to have some tests around this (if there aren't any already). Plus, @bjorn3 are you a +1 on this? I believe you may be the one most interested in this. (I checked and apparently there are some other dependents of this so it isn't just @bjorn3).
Contributor
Author
I've added some simple tests and have cleaned up the PR a bit. |
bjorn3
reviewed
Apr 7, 2025
bjorn3
approved these changes
Apr 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Whoops, sorry. Didn't realize that only a subset of the CI jobs runs on posted PRs ^^ |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2025
* cranelift-jit: add bump memory allocator, make configurable This adds a new JIT memory allocator which operates on an address range that is reserved up-front. This is useful in order to side-step issues where allocation behavior affect relocations, i.e. on x86 where we run into issues when the system allocator returns memory that is more than 4 GiB apart. The main drawback of this allocator option is that the memory range has to be reserved up-front, so allocation will fail if this space is exhausted. This commit: - adds a 'JITMemoryProvider' trait - moves the previous on-demand allocator to this trait - adds a new 'Arena' allocator * ArenaMemoryProvider: add tests, simplify alignment logic * ArenaMemoryProvider: add asserts * Move pipeline flush back out of `set_readable_and_executable` * Fix aarch64 build
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
honzasp
added a commit
to KeyrockEU/wasmtime
that referenced
this pull request
Oct 1, 2025
Send was implemented for JITModule in bytecodealliance#8718, but this was (likely intentionally) broken in bytecodealliance#10512. This commit implements Send again and adds a test to guard against any future regressions.
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
Send was implemented for JITModule in bytecodealliance#8718, but this was (likely intentionally) broken in bytecodealliance#10512. This commit implements Send again and adds a test to guard against any future regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
this is a stab at #4000 (and #4986) to resolve an issue with x86 relocation range that comes up in multi-threaded JITs.
I've added an option to swap out the memory allocator in
cranelift-jitand have added an arena-based option that works with a pre-allocatedPROT_NONEregion.I've marked this as draft because I could also see updating the PR to either
Let me know if this seems reasonable. Thanks! 🙂