Cranelift: Get tail calls working on aarch64#6723
Merged
fitzgen merged 2 commits intobytecodealliance:mainfrom Jul 22, 2023
Merged
Cranelift: Get tail calls working on aarch64#6723fitzgen merged 2 commits intobytecodealliance:mainfrom
fitzgen merged 2 commits intobytecodealliance:mainfrom
Conversation
github-actions
bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
jameysharp
reviewed
Jul 13, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
I haven't reviewed all of this but ran out of time for today. Overall I think it's right but would like somebody else to take a look. For now I have one minor suggestion.
fitzgen
force-pushed
the
aarch64-tail-calls
branch
from
6d00449 to
779f768
Compare
Contributor
|
Could you also enable tail calls for AArch64 on fuzzgen, here? I've been fuzzing this over that past couple of days and it seems fairly stable. |
fitzgen
force-pushed
the
aarch64-tail-calls
branch
from
779f768 to
e96a11c
Compare
Member
Author
Good catch, thanks! Done. |
Co-Authored-By: Jamey Sharp <jsharp@fastly.com>
fitzgen
force-pushed
the
aarch64-tail-calls
branch
from
e96a11c to
1a1a1bc
Compare
fitzgen
requested review from
elliottt and
jameysharp
and removed request for
jameysharp
elliottt
approved these changes
Jul 21, 2023
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks great to me, thank you for all the comments!
Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
Contributor
|
Oops, miss click sorry |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
geekbeast
pushed a commit
to geekbeast/wasmtime
that referenced
this pull request
Aug 1, 2023
* main: (47 commits) Add core dump support to the runtime (bytecodealliance#6513) Resource table tracks child relationships (bytecodealliance#6779) Wasmtime: Move `OnDemandInstanceAllocator` to its own module (bytecodealliance#6790) wasi: Test the stdio streams implementation (bytecodealliance#6764) Don't generate same-named imports in fact modules (bytecodealliance#6783) Wasmtime: Add support for Wasm tail calls (bytecodealliance#6774) Cranelift: Fix `ABIMachineSpec::gen_add_imm` for riscv64 (bytecodealliance#6780) Update the wasm-tools family of crates, disallow empty component types (bytecodealliance#6777) Fix broken link to WASI API documentation (bytecodealliance#6775) A bunch of cleanups for cranelift-codegen-meta (bytecodealliance#6772) Implement component-to-component calls with resources (bytecodealliance#6769) Ignore async_stack_size if async_support is disabled (bytecodealliance#6771) A bunch of minor cleanups (bytecodealliance#6767) Fix flaky tests in preview2 streams (bytecodealliance#6763) Refactor and simplify component trampolines (bytecodealliance#6751) Cranelift: Implement tail calls on riscv64 (bytecodealliance#6749) WASI Preview 2: rewrite streams and pollable implementation (bytecodealliance#6556) cranelift-wasm: Add support for translating Wasm tail calls to CLIF (bytecodealliance#6760) Cranelift: Get tail calls working on aarch64 (bytecodealliance#6723) Implement component model resources in Wasmtime (bytecodealliance#6691) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.