Update the wasm-tools family of crates, disallow empty component types#6777
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom Jul 26, 2023
Merged
Conversation
These files aren't actually read by anything currently. They were added historically and a previous refactoring in bytecodealliance#6390 forgot to remove them. No tests or build process reads them so this deletes them to get them out of the way.
This commit updates the deps on the wasm-tools family of crates to bring in a few fixes for WIT/component-related things. Primarily though this brings in an update to the component model where empty types are now disallowed. Some tests using empty types were adjusted to use non-empty types, but many tests were also simply removed as they existed to test what would happen with empty types which now no longer needs to be tested.
Add a `dummy` field to make it a non-empty structure. It's expected that this will change to something else more "official" in the future, but for now this is here to keep everything compiling.
Empty types are no longer valid
github-actions
bot
added
wasi
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasi", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
pchickey
approved these changes
Jul 26, 2023
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
I had never noticed that dead wit code, thanks
peterhuene
approved these changes
Jul 26, 2023
Member
|
Looks like Pat beat me to the review after all 😅 ; I was going to sneak in a review quickly so we can get this merged as the WASI adapters no longer validate with the latest wasm-tools, preventing me from bumping the deps for |
Co-authored-by: Peter Huene <peter@huene.dev>
auto-merge was automatically disabled
July 26, 2023 18:55
Pull request was closed
geekbeast
pushed a commit
to geekbeast/wasmtime
that referenced
this pull request
Aug 1, 2023
* main: (47 commits) Add core dump support to the runtime (bytecodealliance#6513) Resource table tracks child relationships (bytecodealliance#6779) Wasmtime: Move `OnDemandInstanceAllocator` to its own module (bytecodealliance#6790) wasi: Test the stdio streams implementation (bytecodealliance#6764) Don't generate same-named imports in fact modules (bytecodealliance#6783) Wasmtime: Add support for Wasm tail calls (bytecodealliance#6774) Cranelift: Fix `ABIMachineSpec::gen_add_imm` for riscv64 (bytecodealliance#6780) Update the wasm-tools family of crates, disallow empty component types (bytecodealliance#6777) Fix broken link to WASI API documentation (bytecodealliance#6775) A bunch of cleanups for cranelift-codegen-meta (bytecodealliance#6772) Implement component-to-component calls with resources (bytecodealliance#6769) Ignore async_stack_size if async_support is disabled (bytecodealliance#6771) A bunch of minor cleanups (bytecodealliance#6767) Fix flaky tests in preview2 streams (bytecodealliance#6763) Refactor and simplify component trampolines (bytecodealliance#6751) Cranelift: Implement tail calls on riscv64 (bytecodealliance#6749) WASI Preview 2: rewrite streams and pollable implementation (bytecodealliance#6556) cranelift-wasm: Add support for translating Wasm tail calls to CLIF (bytecodealliance#6760) Cranelift: Get tail calls working on aarch64 (bytecodealliance#6723) Implement component model resources in Wasmtime (bytecodealliance#6691) ...
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Aug 18, 2023
bytecodealliance#6777) * Remove unused WIT files from Wasmtime These files aren't actually read by anything currently. They were added historically and a previous refactoring in bytecodealliance#6390 forgot to remove them. No tests or build process reads them so this deletes them to get them out of the way. * Update dependencies on wasm-tools crates. This commit updates the deps on the wasm-tools family of crates to bring in a few fixes for WIT/component-related things. Primarily though this brings in an update to the component model where empty types are now disallowed. Some tests using empty types were adjusted to use non-empty types, but many tests were also simply removed as they existed to test what would happen with empty types which now no longer needs to be tested. * Update `stream-error` in preview2 Add a `dummy` field to make it a non-empty structure. It's expected that this will change to something else more "official" in the future, but for now this is here to keep everything compiling. * Update component fuzzing to avoid empty types Empty types are no longer valid * Update crates/wasi/wit/deps/io/streams.wit Co-authored-by: Peter Huene <peter@huene.dev> --------- Co-authored-by: Peter Huene <peter@huene.dev>
rvolosatovs
pushed a commit
to rvolosatovs/wasi-io
that referenced
this pull request
Aug 24, 2023
bytecodealliance/wasmtime#6777) * Remove unused WIT files from Wasmtime These files aren't actually read by anything currently. They were added historically and a previous refactoring in #6390 forgot to remove them. No tests or build process reads them so this deletes them to get them out of the way. * Update dependencies on wasm-tools crates. This commit updates the deps on the wasm-tools family of crates to bring in a few fixes for WIT/component-related things. Primarily though this brings in an update to the component model where empty types are now disallowed. Some tests using empty types were adjusted to use non-empty types, but many tests were also simply removed as they existed to test what would happen with empty types which now no longer needs to be tested. * Update `stream-error` in preview2 Add a `dummy` field to make it a non-empty structure. It's expected that this will change to something else more "official" in the future, but for now this is here to keep everything compiling. * Update component fuzzing to avoid empty types Empty types are no longer valid * Update crates/wasi/wit/deps/io/streams.wit Co-authored-by: Peter Huene <peter@huene.dev> --------- Co-authored-by: Peter Huene <peter@huene.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the wasm-tools family of crates which notably brings in a change to disallow empty types in the component model. There were a number of tests and fuzz-related things to update, but the "main" change here is that the
stream-errortype in WASI is growing adummy: u32field as a simple way to keep things compiling. This'll also hopefully emphasize that this is a transitionary state where it'll get updated in the future to be a non-empty type.