Add new "unit" and "bool" primitive types#204
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 22, 2022
Merged
Add new "unit" and "bool" primitive types#204alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This splits out the `bool` type from `Variant` and additionally adds a new `unit` type. The new `unit` type will need some more tests in the future and this is just laying the groundwork for it for now. This'll soon get automatically tested though as the type of each case in `Variant` becomes required and functions will also switch to one return type.
This was referenced Apr 21, 2022
peterhuene
approved these changes
Apr 21, 2022
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
This splits out the `bool` type from `Variant` and additionally adds a new `unit` type. The new `unit` type will need some more tests in the future and this is just laying the groundwork for it for now. This'll soon get automatically tested though as the type of each case in `Variant` becomes required and functions will also switch to one return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the
booltype fromVariantand additionally adds anew
unittype. The newunittype will need some more tests in thefuture and this is just laying the groundwork for it for now. This'll
soon get automatically tested though as the type of each case in
Variantbecomes required and functions will also switch to one returntype.