Change functions to have one return value#206
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Apr 22, 2022
Merged
Change functions to have one return value#206alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
Member
Author
21 tasks
This commit changes wit-defined functions to have precisely one return value instead of a list of return values. This matches the upstream component-model draft specification and canonical ABI. The main fallout here is that the spidermonkey tests stopped testing multiple-returns since while multi-value was implemented struct lifting/lowering is not yet implemented. Otherwise this is relatively straightforward although there are a few gotchas here and there as some language like JS, Python, and C don't have native tuple types and we still want to generate reasonable-ish code.
alexcrichton
force-pushed
the
function-one-return
branch
from
9917fd6 to
204372a
Compare
peterhuene
approved these changes
Apr 22, 2022
willemneal
pushed a commit
to theahaco/wit-bindgen
that referenced
this pull request
May 31, 2022
This commit changes wit-defined functions to have precisely one return value instead of a list of return values. This matches the upstream component-model draft specification and canonical ABI. The main fallout here is that the spidermonkey tests stopped testing multiple-returns since while multi-value was implemented struct lifting/lowering is not yet implemented. Otherwise this is relatively straightforward although there are a few gotchas here and there as some language like JS, Python, and C don't have native tuple types and we still want to generate reasonable-ish code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes wit-defined functions to have precisely one return
value instead of a list of return values. This matches the upstream
component-model draft specification and canonical ABI. The main fallout
here is that the spidermonkey tests stopped testing multiple-returns
since while multi-value was implemented struct lifting/lowering is not
yet implemented. Otherwise this is relatively straightforward although
there are a few gotchas here and there as some language like JS, Python,
and C don't have native tuple types and we still want to generate
reasonable-ish code.