Synchronize the wit-bindgen type AST with the component model#318
Merged
alexcrichton merged 4 commits intobytecodealliance:mainfrom Sep 22, 2022
Merged
Synchronize the wit-bindgen type AST with the component model#318alexcrichton merged 4 commits intobytecodealliance:mainfrom
alexcrichton merged 4 commits intobytecodealliance:mainfrom
Conversation
This PR updates wit-bindgen for the latest changes to the component model: - the return of multireturn - removal of the `unit` type - a new syntax for optional types in results, streams, futures and variants all of which go hand in hand. This also pulls in the latest versions of wasm-encoder, wasmprinter, and wasmparser crates to get their updates for these component model changes.
Exercise this throughout the runtime tests and additionally add a few variants in codegen tests to ensure that this is exercised.
peterhuene
approved these changes
Sep 21, 2022
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Looks great! Thanks for updating wit-component as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, with @kulakowski-wasm, brings the wit-bindgen AST up-to-date with the component model. Namely the changes implemented here are:
Variantwith a non-optional payload type #220.unittype is removed, partially reverting Add new "unit" and "bool" primitive types #204.resulttype has itsokanderrvariants as now optional.This PR was mostly test-driven where the core changes were made to the AST and ABI code and everything else fell out from basically getting
cargo test --workspaceworking.This is additionally one of the first steps I hope to make towards #314 since if Wasmtime is to consume components the generator and Wasmtime need to agree on encodings which requires
wasm-encoderand such to be updated inwit-componentwhich requires these AST changes.