m680x: remove calls to fprintf, abort#1485
Closed
tmfink wants to merge 1 commit intocapstone-engine:nextfrom
Closed
m680x: remove calls to fprintf, abort#1485tmfink wants to merge 1 commit intocapstone-engine:nextfrom
tmfink wants to merge 1 commit intocapstone-engine:nextfrom
Conversation
fprintf is not suitable for kernel code other other environments. Libraries should not exit with abort.
tmfink
commented
May 17, 2019
| fprintf(stderr, "Internal error: Unexpected operand0 register " | ||
| "%d\n", op0->reg); | ||
| abort(); | ||
| // Should never happen |
Contributor
Author
There was a problem hiding this comment.
Does this make sense?
Collaborator
|
@aladur please ack. |
Contributor
Author
|
handled with #1489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1483
fprintf is not suitable for kernel code other other environments.
Libraries should not exit with abort.