[M680X] Fix #1483: errors logged to stderr, using abort.#1487
Closed
aladur wants to merge 1 commit intocapstone-engine:nextfrom
Closed
[M680X] Fix #1483: errors logged to stderr, using abort.#1487aladur wants to merge 1 commit intocapstone-engine:nextfrom
aladur wants to merge 1 commit intocapstone-engine:nextfrom
Conversation
- This is not suitable for an application framework especially for kernel code. - All these error conditions do not occur under normal conditions. They only can occur if a maintainer (in the future) would make inappropriate changes to the M680X code base. - The commented out assert's help the maintainer when e.g. adding new M680X cpu types.
tmfink
suggested changes
May 18, 2019
Collaborator
|
so this PR overlaps with #1485? |
Contributor
Author
Contributor
Author
|
Closed this one. New PR #1489 provides a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
especially for kernel code.
They only can occur if a maintainer (in the future) would make
inappropriate changes to the M680X code base.
adding new M680X cpu types.