[M680X] Fix #1483: errors logged to stderr, using abort (2)#1489
Merged
aquynh merged 1 commit intocapstone-engine:nextfrom May 20, 2019
Merged
[M680X] Fix #1483: errors logged to stderr, using abort (2)#1489aquynh merged 1 commit intocapstone-engine:nextfrom
aquynh merged 1 commit intocapstone-engine:nextfrom
Conversation
tmfink
suggested changes
May 18, 2019
| #include <stdlib.h> | ||
| #include <stdio.h> | ||
| #include <string.h> | ||
| #ifdef CAPSTONE_DEBUG |
Contributor
There was a problem hiding this comment.
We could move this into cs_priv.h so that other files don't need to manually include.
Contributor
|
We should also document this macro. |
Collaborator
|
Yes please document in in compilation doc.
|
…t (2) - This is not suitable for an application framework especially for kernel code. - All these error conditions do not occur under normal conditions. They only can occur if a maintainer (in the future) would make inappropriate changes to the M680X code base. - Added CS_ASSERT macro which allows to use assertions when debugging by defining CAPSTONE_DEBUG. - Updated compiler documenation
Contributor
|
Looks good to me. |
Collaborator
|
merged, thanks! |
aquynh
pushed a commit
that referenced
this pull request
May 20, 2019
- This is not suitable for an application framework especially for kernel code. - All these error conditions do not occur under normal conditions. They only can occur if a maintainer (in the future) would make inappropriate changes to the M680X code base. - Added CS_ASSERT macro which allows to use assertions when debugging by defining CAPSTONE_DEBUG. - Updated compiler documenation
Contributor
|
@aladur nice work! Could you make a PR for |
Collaborator
|
I already cherrypicked for v4.
Can anyone fix this issue for RISCV?
|
Contributor
|
@aquynh I'll handle RISCV |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
especially for kernel code.
They only can occur if a maintainer (in the future) would make
inappropriate changes to the M680X code base.