Skip to content

NO-TICK: removing public net#28

Merged
TomVasile merged 2 commits intomasterfrom
NO-TICK-remove-public-net
Jun 17, 2020
Merged

NO-TICK: removing public net#28
TomVasile merged 2 commits intomasterfrom
NO-TICK-remove-public-net

Conversation

@TomVasile
Copy link
Contributor

@TomVasile TomVasile commented Jun 17, 2020

Feel free to close this if I removed something I shouldn't have.

@afck
Copy link
Contributor

afck commented Jun 17, 2020

Isn't it rather the validator_net that gets removed?

@TomVasile
Copy link
Contributor Author

TomVasile commented Jun 17, 2020

@afck I was just going off of a discussion in slack where Fraser mentioned getting rid of public_net

@afck
Copy link
Contributor

afck commented Jun 17, 2020

OK; it's just a name, of course.
But I think the network we remove is the exclusive validator-only one. Instead, validators will communicate via gossip in the network that everyone can join ("public")?

@Fraser999
Copy link
Contributor

Fraser999 commented Jun 17, 2020

I'd be good to merge this as is, but as part of cleaning up in a later PR, I'd rename validator_net to just network inside the top level config file. Any objections @TomVasile, @EdHastingsCasperLabs or @afck?

@TomVasile
Copy link
Contributor Author

TomVasile commented Jun 17, 2020

no objections here

@TomVasile TomVasile merged commit 524ed08 into master Jun 17, 2020
@TomVasile TomVasile deleted the NO-TICK-remove-public-net branch June 19, 2020 14:39
mpapierski pushed a commit to mpapierski/casper-node that referenced this pull request Feb 9, 2022
@casperlabs-bors-ng @marc-casperlabs @fizyk20
Merge casper-network#28
f09dcd7 
28: Include approvals in block payloads r=fizyk20 a=fizyk20

This PR:
- makes block payloads include approvals to be used for execution
- stores the set of finalized approvals when a block is finalized
- updates the `get_deploy` API by adding a flag to choose whether the finalized approvals should be returned, or the original ones.

Related issues:
https://github.com/casper-network/Governance/issues/117
https://github.com/casper-network/Governance/issues/119
https://github.com/casper-network/Governance/issues/120

Co-authored-by: Marc Brinkmann <marc@casperlabs.io>
Co-authored-by: Bartłomiej Kamiński <bart@casperlabs.io>
alsrdn pushed a commit to alsrdn/casper-node that referenced this pull request Apr 25, 2024
@EdHastingsCasperAssociation
Merge pull request casper-network#28 from alsrdn/amortized-payment-tests
0210eed 
reactor_tests: fix lint errors
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
@vlopes11
Add Bytes64 transaction type (#28)
72fcb42 
Arrays bigger than 32 bytes won't benefit from default blanket
implementations for Distribution, Default and Serde

Bytes64 requires a dedicated implementation
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
@Voxelot @vlopes11
use new feature syntax for optional deps (#28)
0fe2b6d 
* use new feature syntax for optional deps

* Update safety comments of bytes functions

Co-authored-by: Victor Lopes <vhrlopes@gmail.com>
rafal-ch pushed a commit that referenced this pull request Sep 11, 2024
@digorithm
Move mnemonic logic from the SDK (#28)
50ddde1 
* Move mnemonic logic from the SDK

Note that these changes include some dependencies updates that were
forced onto us because of conflicting deps' versions in the bip32/bip39
crates.

With these dependencies updates, some updates on our end also had to be done. 
Small things such as replacing deprecated methods with new ones, etc.
zajko added a commit to zajko/casper-node that referenced this pull request Oct 13, 2025
@zajko
# This is a combination of 29 commits.
d0da6e3 
# This is the 1st commit message:

rebasing

# The commit message #2 will be skipped:

# WIP

# The commit message #3 will be skipped:

# WIP

# The commit message #4 will be skipped:

# wip

# The commit message #5 will be skipped:

# wip

# The commit message #6 will be skipped:

# wip

# The commit message #7 will be skipped:

# wip

# The commit message #8 will be skipped:

# wip

# The commit message #9 will be skipped:

# wip

# The commit message casper-network#10 will be skipped:

# wip

# The commit message casper-network#11 will be skipped:

# wip

# The commit message casper-network#12 will be skipped:

# wip

# The commit message casper-network#13 will be skipped:

# rebasing

# The commit message casper-network#14 will be skipped:

# wip

# The commit message casper-network#15 will be skipped:

# wip

# The commit message casper-network#16 will be skipped:

# wip

# The commit message casper-network#17 will be skipped:

# wip

# The commit message casper-network#18 will be skipped:

# wip

# The commit message casper-network#19 will be skipped:

# wip

# The commit message casper-network#20 will be skipped:

# rebasing

# The commit message casper-network#21 will be skipped:

# wip

# The commit message casper-network#22 will be skipped:

# wip

# The commit message casper-network#23 will be skipped:

# wip

# The commit message casper-network#24 will be skipped:

# wip

# The commit message casper-network#25 will be skipped:

# wip

# The commit message casper-network#26 will be skipped:

# wip

# The commit message casper-network#27 will be skipped:

# wip

# The commit message casper-network#28 will be skipped:

# wip

# The commit message casper-network#29 will be skipped:

# wip
zajko added a commit to zajko/casper-node that referenced this pull request Oct 13, 2025
@zajko
# This is a combination of 32 commits.
599c5c7 
# This is the 1st commit message:

rebasing

# The commit message #2 will be skipped:

# WIP

# The commit message #3 will be skipped:

# WIP

# The commit message #4 will be skipped:

# wip

# The commit message #5 will be skipped:

# wip

# The commit message #6 will be skipped:

# wip

# The commit message #7 will be skipped:

# wip

# The commit message #8 will be skipped:

# wip

# The commit message #9 will be skipped:

# wip

# The commit message casper-network#10 will be skipped:

# wip

# The commit message casper-network#11 will be skipped:

# wip

# The commit message casper-network#12 will be skipped:

# wip

# The commit message casper-network#13 will be skipped:

# rebasing

# The commit message casper-network#14 will be skipped:

# wip

# The commit message casper-network#15 will be skipped:

# wip

# The commit message casper-network#16 will be skipped:

# wip

# The commit message casper-network#17 will be skipped:

# wip

# The commit message casper-network#18 will be skipped:

# wip

# The commit message casper-network#19 will be skipped:

# wip

# The commit message casper-network#20 will be skipped:

# rebasing

# The commit message casper-network#21 will be skipped:

# wip

# The commit message casper-network#22 will be skipped:

# wip

# The commit message casper-network#23 will be skipped:

# wip

# The commit message casper-network#24 will be skipped:

# wip

# The commit message casper-network#25 will be skipped:

# wip

# The commit message casper-network#26 will be skipped:

# wip

# The commit message casper-network#27 will be skipped:

# wip

# The commit message casper-network#28 will be skipped:

# wip

# The commit message casper-network#29 will be skipped:

# wip

# The commit message casper-network#30 will be skipped:

# wip

# The commit message casper-network#31 will be skipped:

# wip

# The commit message casper-network#32 will be skipped:

# wip
zajko added a commit to zajko/casper-node that referenced this pull request Oct 13, 2025
@zajko
# This is a combination of 40 commits.
1759a90 
# This is the 1st commit message:

rebasing

# The commit message #2 will be skipped:

# WIP

# The commit message #3 will be skipped:

# WIP

# The commit message #4 will be skipped:

# wip

# The commit message #5 will be skipped:

# wip

# The commit message #6 will be skipped:

# wip

# The commit message #7 will be skipped:

# wip

# The commit message #8 will be skipped:

# wip

# The commit message #9 will be skipped:

# wip

# The commit message casper-network#10 will be skipped:

# wip

# The commit message casper-network#11 will be skipped:

# wip

# The commit message casper-network#12 will be skipped:

# wip

# The commit message casper-network#13 will be skipped:

# rebasing

# The commit message casper-network#14 will be skipped:

# wip

# The commit message casper-network#15 will be skipped:

# wip

# The commit message casper-network#16 will be skipped:

# wip

# The commit message casper-network#17 will be skipped:

# wip

# The commit message casper-network#18 will be skipped:

# wip

# The commit message casper-network#19 will be skipped:

# wip

# The commit message casper-network#20 will be skipped:

# rebasing

# The commit message casper-network#21 will be skipped:

# wip

# The commit message casper-network#22 will be skipped:

# wip

# The commit message casper-network#23 will be skipped:

# wip

# The commit message casper-network#24 will be skipped:

# wip

# The commit message casper-network#25 will be skipped:

# wip

# The commit message casper-network#26 will be skipped:

# wip

# The commit message casper-network#27 will be skipped:

# wip

# The commit message casper-network#28 will be skipped:

# wip

# The commit message casper-network#29 will be skipped:

# wip

# The commit message casper-network#30 will be skipped:

# wip

# The commit message casper-network#31 will be skipped:

# wip

# The commit message casper-network#32 will be skipped:

# wip

# The commit message casper-network#33 will be skipped:

# wip

# The commit message casper-network#34 will be skipped:

# wip

# The commit message casper-network#35 will be skipped:

# wip

# The commit message casper-network#36 will be skipped:

# wip

# The commit message casper-network#37 will be skipped:

# wip

# The commit message casper-network#38 will be skipped:

# wip

# The commit message casper-network#39 will be skipped:

# wip

# The commit message casper-network#40 will be skipped:

# rebasing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EdHastingsCasperAssociation EdHastingsCasperAssociation Awaiting requested review from EdHastingsCasperAssociation

@marc-casperlabs marc-casperlabs Awaiting requested review from marc-casperlabs

1 more reviewer

@Fraser999 Fraser999 Fraser999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomVasile @afck @Fraser999