Skip to content

Conversation

@MBcode
Copy link
Contributor

@MBcode MBcode commented Mar 2, 2022

Description file/dataset add schema.org

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

MBcode added 2 commits March 2, 2022 17:29
mapping file class elts to schema.org
dataset elts mapping to schema.org; needs some struct formatting, and will drop d+m at the end
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

@MBcode
Copy link
Contributor Author

MBcode commented Mar 3, 2022

It still needs a little formatting, eg. for authour..
and
I would like to add @id's for every page's json-ld
then in the 'dataset', I can just ref the @id of the 'file's jsonLD
even though the sitemap(coming soon), usually only go to those 1st dataset pages
So I might bring it up into the dataset page

I had this under a branch called schema.org, but this 1st cut only has metadata from those 2 classes
So am calling it: class2SOmetadata, later we can consider mapping elts from the metadata editor
and just using any attached uploaded jsonld

MBcode and others added 11 commits March 11, 2022 10:59
start of method to see license url only now, as json-ld
use new method for license as json-ld
MiniUser to_jsonld but has problems with embedded quotes, will fix soon
call Miniuser to_jsonld which has an embedded quote problem
also removed test elts that shouldn't go in the final page
misspelling in context
construct as one JsObject but even replaceAll isn't getting rid of the " s yet
@html(dataset.author.to_jsonld()) keeps as unescaped html
don't need replace, will @html(dataset.author.to_jsonld()) in the call
import play.api.libs.json._ ;rm un-needed vars
file.author miniUser also to_jsonld
@robkooper robkooper changed the title Class2 s ometadata file/dataset add schema.org Mar 24, 2022
@MBcode
Copy link
Contributor Author

MBcode commented Mar 29, 2022

No sitemap generation in this go, but do have File and Dataset attributes mapped to schema.org predicates and embedded in each of those pages as ld+json that can be parsed by https://validator.schema.org More in #335

@MBcode MBcode marked this pull request as ready for review March 29, 2022 15:02
@MBcode MBcode requested a review from robkooper March 29, 2022 15:02
@lmarini lmarini self-requested a review March 31, 2022 15:34
@MBcode MBcode marked this pull request as ready for review April 28, 2022 21:37
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll play a bit more with it in the next couple of days, but I wanted to leave a couple of quick comments. Thanks!

@robkooper robkooper added this to the 1.21.0 milestone Aug 26, 2022
@robkooper robkooper merged commit 2819451 into clowder-framework:develop Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants