Skip to content

Email in lowercase #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Didayolo merged 3 commits into from
Mar 21, 2025
Merged

Email in lowercase #1769

Didayolo merged 3 commits into from
Mar 21, 2025

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Mar 5, 2025 •
edited by Didayolo
Loading

@Didayolo

Description

  • On signup emails are stored as lowercased to not allow users to create multiple accounts using the same email but in different cases
  • White list emails are now checked in lower case to avoid any inconsistencies

Issues this PR resolves

A checklist for hand testing

  • signup with a dummy uppercased email e.g. AAA@gmail.com and check in your profile that it is stored as aaa@gmail.com
  • Add AAA@gmail.com to a competition whitelist and check that when you join the competition with aaa@gmail.com it approves you automatically

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Mar 5, 2025 that may be closed by this pull request
🔥 Whitelist emails are leaked from API & should be case-insensitive #1766
Closed
2 tasks
@hzxie
Copy link

hzxie commented Mar 6, 2025

Thanks for creating this PR.

@Didayolo Didayolo self-assigned this Mar 7, 2025
@Didayolo
Copy link
Member

Didayolo commented Mar 21, 2025

@ihsaan-ullah

For me this change can be slightly problematic: Someone registering with an uppercase in the email will not be able to login typing the email in the same way the next time.

I think we should either:

  • Prevent from filling the form with uppercase,
  • or allowing to login with uppercase in the field (even if we sanitize it before comparing it to database). Maybe this method is prefered.

@ihsaan-ullah
Copy link
Collaborator Author

ihsaan-ullah commented Mar 21, 2025

  • or allowing to login with uppercase in the field (even if we sanitize it before comparing it to database). Maybe this method is preferred.

I updated the code to use lowercased email during login. This will allow users to use both lower and upper cased emails

@Didayolo Didayolo merged commit 661a680 into develop Mar 21, 2025
1 check passed
@Didayolo Didayolo deleted the whitelist branch March 21, 2025 12:10
@Didayolo Didayolo mentioned this pull request Mar 21, 2025
Merged
curious-broccoli added a commit to curious-broccoli/codabench that referenced this pull request May 27, 2025
@curious-broccoli @ihsaan-ullah
@Didayolo @ObadaS @actions-user
merge upstream 1.19.0 (#5)
3344325 
* show server error instead of fronend parsing error

* show back button in edit only. Show help in create only

* do not allow special chars in usernames

* Enable/Disable competition forum (codalab#1774)

* forum enable/disable functionality added

* new forum_enabled field added to competition dump data

* Email in lowercase (codalab#1769)

* on signup email stored in lower case letters. Whitelist emails conveted to lowercased

* whitespace removed

* convert email to lowercased during login

* latest competition fields added to dump (codalab#1786)

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* User quota is updated to GB from Bytes (codalab#1749)

* user assigned quota will now be in GB instead of bytes

* unused counter removed

* File Sizes cleanup (codalab#1752)

* sizes Kib to Bytes, size formatting functions cleanup

* space between size and unit, removed factor multiplication from size calcualtion

* file_size to bytes in SubmissionDetail

* added missing migration

* migration conflict resolved

* reseting file sizes task removed

* Resource interface: quota unit is now GB instead of B

* Create CODE_OF_CONDUCT.md

* Added log rolling to limit log size to 5GB for now, can be changed

* Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory (codalab#1799)

* Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory

* Add offline.png

* Fixed image not loading

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: didayolo <adrien.pavao@gmail.com>

* Update version.json for release 1.18.0

* Add remove button for cancelled submissions (codalab#1808)

* Add remove button for cancelled submissions

* Allow remove of cancelled submissions

* Update compute_worker.py

* Add permissions check for bulk download

* flake8 fix

* Add hide_score_output option (codalab#1838)

* Add hide_score_output option

* Update test

* Add the options for v1 bundles

* Make more generic tests (v1, v2)

* version update workflow removed

* Add hide_prediction_output feature

* Calendar lock fixed, additional check added for start and end date

* Simplify code

* Version bump

* Removed time and updated date to today

---------

Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Obada Haddad-Soussac <11889208+ObadaS@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Didayolo Didayolo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🔥 Whitelist emails are leaked from API & should be case-insensitive

4 participants

@ihsaan-ullah @hzxie @Didayolo