Skip to content

Conversation

@Didayolo
Copy link
Member

@Didayolo Didayolo commented Apr 4, 2025

Mention potential reviewers

@ihsaan-ullah

Description

Add the "Delete Submission" button in "My submissions" for cancelled submissions.

Issues this PR resolves

A checklist for hand testing

  • Upload several submissions, cancel some of them
  • Try to remove the submissions as a participant

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo linked an issue Apr 4, 2025 that may be closed by this pull request
@Didayolo Didayolo requested review from ihsaan-ullah and removed request for ihsaan-ullah April 4, 2025 13:31
@ihsaan-ullah
Copy link
Collaborator

I tested this locally. The functinality works:

  • I see delete button in front of cancelled submissions
  • I can delete soft-delete cancelled submissions

@Didayolo Didayolo merged commit d188aea into develop Apr 13, 2025
1 check passed
@Didayolo Didayolo deleted the remove-submissions branch April 13, 2025 18:26
curious-broccoli added a commit to curious-broccoli/codabench that referenced this pull request May 27, 2025
* show server error instead of fronend parsing error

* show back button in edit only. Show help in create only

* do not allow special chars in usernames

* Enable/Disable competition forum (codalab#1774)

* forum enable/disable functionality added

* new forum_enabled field added to competition dump data

* Email in lowercase (codalab#1769)

* on signup email stored in lower case letters. Whitelist emails conveted to lowercased

* whitespace removed

* convert email to lowercased during login

* latest competition fields added to dump (codalab#1786)

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>

* User quota is updated to GB from Bytes (codalab#1749)

* user assigned quota will now be in GB instead of bytes

* unused counter removed

* File Sizes cleanup (codalab#1752)

* sizes Kib to Bytes, size formatting functions cleanup

* space between size and unit, removed factor multiplication from size calcualtion

* file_size to bytes in SubmissionDetail

* added missing migration

* migration conflict resolved

* reseting file sizes task removed

* Resource interface: quota unit is now GB instead of B

* Create CODE_OF_CONDUCT.md

* Added log rolling to limit log size to 5GB for now, can be changed

* Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory (codalab#1799)

* Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory

* Add offline.png

* Fixed image not loading

---------

Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: didayolo <adrien.pavao@gmail.com>

* Update version.json for release 1.18.0

* Add remove button for cancelled submissions (codalab#1808)

* Add remove button for cancelled submissions

* Allow remove of cancelled submissions

* Update compute_worker.py

* Add permissions check for bulk download

* flake8 fix

* Add hide_score_output option (codalab#1838)

* Add hide_score_output option

* Update test

* Add the options for v1 bundles

* Make more generic tests (v1, v2)

* version update workflow removed

* Add hide_prediction_output feature

* Calendar lock fixed, additional check added for start and end date

* Simplify code

* Version bump

* Removed time and updated date to today

---------

Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Obada Haddad-Soussac <11889208+ObadaS@users.noreply.github.com>
Co-authored-by: GitHub Actions <actions@github.com>
Didayolo added a commit that referenced this pull request Jul 17, 2025
* consumer async and template static loading changes

* flake problems

* comp participant needs creating

* ORM based issues recified.

* flake message removal

* CONCERN task

* Add remove button for cancelled submissions (#1808)

* Add remove button for cancelled submissions

* Allow remove of cancelled submissions

* more waits added

* flake concerns

* Update compute_worker.py

* Triggering tests with blank line deletion

* flake

* circleci resource_class: medium+

* circleci resource_class: large

* circleci resource_class: xlarge

* Add permissions check for bulk download

* flake8 fix

* Add hide_score_output option (#1838)

* Add hide_score_output option

* Update test

* Add the options for v1 bundles

* Make more generic tests (v1, v2)

* code removed that was copying submission files to predictions dir

* hail mary

* flake

* config

* version update workflow removed

* Add hide_prediction_output feature

* Calendar lock fixed, additional check added for start and end date

* Simplify code

* Version bump

* Removed time and updated date to today

* Caddy image update

* fix Caddyfile indentation

* django to 3.2.0 - but still has websocket errors for test_submissions during tests

* poetry.lock

* removing submissions to pass circleci

* Do not allow signup with email with `*` (#1882)

* fix to run result sbmission(with copy to predictions dir)

* raise error when signing up with an email with *

* revert compute worker changes

* User model filters - remove `deleted` (#1887)

* fix to run result sbmission(with copy to predictions dir)

* removed filter based on

* reverted compute worker changes

* consumer async and template static loading changes

* flake problems

* comp participant needs creating

* ORM based issues recified.

* flake message removal

* CONCERN task

* more waits added

* flake concerns

* Triggering tests with blank line deletion

* flake

* circleci resource_class: medium+

* circleci resource_class: large

* circleci resource_class: xlarge

* hail mary

* flake

* config

* django to 3.2.0 - but still has websocket errors for test_submissions during tests

* poetry.lock

* removing submissions to pass circleci

* integrate dev branch commit: 2883349

* config.yml for circleci

* config.yml for circleci

* spelling mistake

* timing issues

* flake

* timing issues

* timing issues

* timing issues

* timing issues

* logger.info -> logger.debug changes

* test just selenium submissions

* time adjustment

* separating out submissions to see if one is particulary troublesome

* time adjustment

* time adjustment

* docker images

* submissions in batch

* all

* final clean up

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Moritz <moritz.mueller2@tu-dresden.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't remove cancelled submissions from "My submissions"

3 participants