Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Jun 18, 2025

@Didayolo

Description

This PR removes the unused deleted filter from the users model in the django admin interface.

Before:
Screenshot 2025-06-18 at 5 41 54 PM

After:
Screenshot 2025-06-18 at 5 42 20 PM

Issues this PR resolves

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@ihsaan-ullah ihsaan-ullah linked an issue Jun 18, 2025 that may be closed by this pull request
@Didayolo
Copy link
Member

@ihsaan-ullah Is it normal that the changes of compute_worker.py are reflected in this PR?

@Didayolo Didayolo self-assigned this Jun 19, 2025
@ihsaan-ullah
Copy link
Collaborator Author

This was a mistake. Now it should be ok

@Didayolo Didayolo merged commit ac30787 into develop Jun 20, 2025
1 check passed
@Didayolo Didayolo deleted the user_model_filters branch June 20, 2025 13:06
Didayolo added a commit that referenced this pull request Jul 17, 2025
* consumer async and template static loading changes

* flake problems

* comp participant needs creating

* ORM based issues recified.

* flake message removal

* CONCERN task

* Add remove button for cancelled submissions (#1808)

* Add remove button for cancelled submissions

* Allow remove of cancelled submissions

* more waits added

* flake concerns

* Update compute_worker.py

* Triggering tests with blank line deletion

* flake

* circleci resource_class: medium+

* circleci resource_class: large

* circleci resource_class: xlarge

* Add permissions check for bulk download

* flake8 fix

* Add hide_score_output option (#1838)

* Add hide_score_output option

* Update test

* Add the options for v1 bundles

* Make more generic tests (v1, v2)

* code removed that was copying submission files to predictions dir

* hail mary

* flake

* config

* version update workflow removed

* Add hide_prediction_output feature

* Calendar lock fixed, additional check added for start and end date

* Simplify code

* Version bump

* Removed time and updated date to today

* Caddy image update

* fix Caddyfile indentation

* django to 3.2.0 - but still has websocket errors for test_submissions during tests

* poetry.lock

* removing submissions to pass circleci

* Do not allow signup with email with `*` (#1882)

* fix to run result sbmission(with copy to predictions dir)

* raise error when signing up with an email with *

* revert compute worker changes

* User model filters - remove `deleted` (#1887)

* fix to run result sbmission(with copy to predictions dir)

* removed filter based on

* reverted compute worker changes

* consumer async and template static loading changes

* flake problems

* comp participant needs creating

* ORM based issues recified.

* flake message removal

* CONCERN task

* more waits added

* flake concerns

* Triggering tests with blank line deletion

* flake

* circleci resource_class: medium+

* circleci resource_class: large

* circleci resource_class: xlarge

* hail mary

* flake

* config

* django to 3.2.0 - but still has websocket errors for test_submissions during tests

* poetry.lock

* removing submissions to pass circleci

* integrate dev branch commit: 2883349

* config.yml for circleci

* config.yml for circleci

* spelling mistake

* timing issues

* flake

* timing issues

* timing issues

* timing issues

* timing issues

* logger.info -> logger.debug changes

* test just selenium submissions

* time adjustment

* separating out submissions to see if one is particulary troublesome

* time adjustment

* time adjustment

* docker images

* submissions in batch

* all

* final clean up

---------

Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com>
Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com>
Co-authored-by: Obada Haddad <obada.haddad@lisn.fr>
Co-authored-by: Moritz <moritz.mueller2@tu-dresden.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django admin User filters - remove deleted

3 participants