Do not allow signup with email with *

[ihsaan-ullah]

@Didayolo

Description

Codabench was allowing users to use emails with * e.g. ihsan*@gmail.com was considered a valid email. Now this will raise an error.

Issues this PR resolves

• Do not allow emails with * #1881

A checklist for hand testing

• try signing up with an email with * in it

Checklist

• Code review by me
• Hand tested by me
• I'm proud of my work
• Code review by reviewer
• Hand tested by reviewer
• CircleCi tests are passing
• Ready to merge

[Didayolo]

@ihsaan-ullah

Shouldn't we make this more general than just not allowing * ?

Like for usernames, I think more characters should be disallowed.

    def clean_username(self):
        data = self.cleaned_data["username"]

        # Check if username has allowed characters only
        # Allow only lowercase letters, numbers, hyphens, and underscores
        if not re.match(r"^[a-z0-9_-]+$", data):
            raise forms.ValidationError("Username can only contain lowercase letters, numbers, hyphens, and underscores.")

        # Check username length
        if (len(data) > 15) or (len(data) < 5):
            raise forms.ValidationError(
                "Username must have at least 5 characters and at most 15 characters"
            )
        return data

    def clean_email(self):
        email = self.cleaned_data["email"]
        if "*" in email:
            raise forms.ValidationError("Email address cannot contain the '*' character.")
        return email

[ihsaan-ullah]

I was not sure what other checks we want to put on email. Unlike usernames emails cannot be restricted too much because they can have different characters but we can still discuss and comeup with more checks

[Didayolo]

I think it is fine this way. I don't even get how people tried to register with * in the first place.