-
Notifications
You must be signed in to change notification settings - Fork 45
Add hide_score_output option #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ObadaS Would you be able to review this one? |
|
Yes I can review it. |
|
Here is the bundle I am using (I modified the final phase) After uploading, I tried to submit something on an another account but I could still download the output. I then checked the competition settings from the interface and I saw that the option is turned off. |
En effet, je n'ai mis à jour que l'unpacker "v2", je n'ai pas pensé au cas de figure où on edit un bundle CodaLab pour y ajouter cette nouvelle option. C'est également le cas de l'option "Hide Submission Output" d'ailleurs. |
|
@ObadaS Done! |
|
The option now works correctly for the custom competition I modified. |
* show server error instead of fronend parsing error * show back button in edit only. Show help in create only * do not allow special chars in usernames * Enable/Disable competition forum (codalab#1774) * forum enable/disable functionality added * new forum_enabled field added to competition dump data * Email in lowercase (codalab#1769) * on signup email stored in lower case letters. Whitelist emails conveted to lowercased * whitespace removed * convert email to lowercased during login * latest competition fields added to dump (codalab#1786) Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com> * User quota is updated to GB from Bytes (codalab#1749) * user assigned quota will now be in GB instead of bytes * unused counter removed * File Sizes cleanup (codalab#1752) * sizes Kib to Bytes, size formatting functions cleanup * space between size and unit, removed factor multiplication from size calcualtion * file_size to bytes in SubmissionDetail * added missing migration * migration conflict resolved * reseting file sizes task removed * Resource interface: quota unit is now GB instead of B * Create CODE_OF_CONDUCT.md * Added log rolling to limit log size to 5GB for now, can be changed * Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory (codalab#1799) * Maintenance mode option added in Caddyfile, used by creating a maintenance.on file in the maintenance_mode/ directory * Add offline.png * Fixed image not loading --------- Co-authored-by: Obada Haddad <obada.haddad@lisn.fr> Co-authored-by: didayolo <adrien.pavao@gmail.com> * Update version.json for release 1.18.0 * Add remove button for cancelled submissions (codalab#1808) * Add remove button for cancelled submissions * Allow remove of cancelled submissions * Update compute_worker.py * Add permissions check for bulk download * flake8 fix * Add hide_score_output option (codalab#1838) * Add hide_score_output option * Update test * Add the options for v1 bundles * Make more generic tests (v1, v2) * version update workflow removed * Add hide_prediction_output feature * Calendar lock fixed, additional check added for start and end date * Simplify code * Version bump * Removed time and updated date to today --------- Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com> Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com> Co-authored-by: Obada Haddad <obada.haddad@lisn.fr> Co-authored-by: Obada Haddad-Soussac <11889208+ObadaS@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com>
* consumer async and template static loading changes * flake problems * comp participant needs creating * ORM based issues recified. * flake message removal * CONCERN task * Add remove button for cancelled submissions (#1808) * Add remove button for cancelled submissions * Allow remove of cancelled submissions * more waits added * flake concerns * Update compute_worker.py * Triggering tests with blank line deletion * flake * circleci resource_class: medium+ * circleci resource_class: large * circleci resource_class: xlarge * Add permissions check for bulk download * flake8 fix * Add hide_score_output option (#1838) * Add hide_score_output option * Update test * Add the options for v1 bundles * Make more generic tests (v1, v2) * code removed that was copying submission files to predictions dir * hail mary * flake * config * version update workflow removed * Add hide_prediction_output feature * Calendar lock fixed, additional check added for start and end date * Simplify code * Version bump * Removed time and updated date to today * Caddy image update * fix Caddyfile indentation * django to 3.2.0 - but still has websocket errors for test_submissions during tests * poetry.lock * removing submissions to pass circleci * Do not allow signup with email with `*` (#1882) * fix to run result sbmission(with copy to predictions dir) * raise error when signing up with an email with * * revert compute worker changes * User model filters - remove `deleted` (#1887) * fix to run result sbmission(with copy to predictions dir) * removed filter based on * reverted compute worker changes * consumer async and template static loading changes * flake problems * comp participant needs creating * ORM based issues recified. * flake message removal * CONCERN task * more waits added * flake concerns * Triggering tests with blank line deletion * flake * circleci resource_class: medium+ * circleci resource_class: large * circleci resource_class: xlarge * hail mary * flake * config * django to 3.2.0 - but still has websocket errors for test_submissions during tests * poetry.lock * removing submissions to pass circleci * integrate dev branch commit: 2883349 * config.yml for circleci * config.yml for circleci * spelling mistake * timing issues * flake * timing issues * timing issues * timing issues * timing issues * logger.info -> logger.debug changes * test just selenium submissions * time adjustment * separating out submissions to see if one is particulary troublesome * time adjustment * time adjustment * docker images * submissions in batch * all * final clean up --------- Co-authored-by: Adrien Pavão <adrien.pavao@gmail.com> Co-authored-by: Ihsan Ullah <ihsan2131@gmail.com> Co-authored-by: Obada Haddad <obada.haddad@lisn.fr> Co-authored-by: Moritz <moritz.mueller2@tu-dresden.de>
Description
New phase option "Hide score output" (also a
competition.yamloption):If checked, it prevents from downloading "Output from scoring step":
It is useful, because the current option "Hide submission output" hide all logs and is too extreme. But in some cases, typically with hidden leaderboard columns, we don't want participants to be able to read the
scores.txtfile.A checklist for hand testing
competition.yamloptionhide_score_output: True(it is a phase option)To check
I added 3 migration files. Maybe we can avoid having that many.
Checklist