mantle: Remove generated cosa schema from git#1306
mantle: Remove generated cosa schema from git#1306cgwalters wants to merge 1 commit intocoreos:masterfrom
Conversation
My recent change to use `make` for this seems to have introduced a race condition mainly in Prow; perhaps something is not preserving timestamps. In the end anyways, files stored in git should not be touched via a default `make`, as that is both subject to timestamp problems and also creates friction. Generating it is cheap, so let's switch to always generating it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The other alternative is to store it in git and require a |
|
I have no opinion on this so I'll let others who do weigh in |
|
Hmm, lukewarm on this, leaning more towards:
The reason is that it's useful to be able to read the golang schema without having to build the code. And IMO reading the original JSON schema is way harder than the generated Go code. This also matches what Ignition does. But anyway, not super strongly against it either if others find it valuable. |
Alternative to coreos#1306 My recent change to use make for this seems to have introduced a race condition mainly in Prow; perhaps something is not preserving timestamps. Files stored in git should not be touched via a default make, as that is both subject to timestamp problems and also creates friction. So this change now requires an explicit manual generation.
|
ok then #1308 |
Alternative to coreos#1306 My recent change to use make for this seems to have introduced a race condition mainly in Prow; perhaps something is not preserving timestamps. Files stored in git should not be touched via a default make, as that is both subject to timestamp problems and also creates friction. So this change now requires an explicit manual generation; and we also consistently add the generated doc file to git too.
|
Closing in favor of the other one |
Alternative to #1306 My recent change to use make for this seems to have introduced a race condition mainly in Prow; perhaps something is not preserving timestamps. Files stored in git should not be touched via a default make, as that is both subject to timestamp problems and also creates friction. So this change now requires an explicit manual generation; and we also consistently add the generated doc file to git too.
4 participants
My recent change to use
makefor this seems to have introduceda race condition mainly in Prow; perhaps something is not
preserving timestamps.
In the end anyways, files stored in git should not be touched
via a default
make, as that is both subject to timestampproblems and also creates friction.
Generating it is cheap, so let's switch to always generating it.