build: Fix race in generating schema#1309
build: Fix race in generating schema#1309openshift-merge-robot merged 1 commit intocoreos:masterfrom
Conversation
|
OK so this PR should fix the issues stalling other PRs; it will work without merging one of the other two options:
But after this lands we should pick one of those two. |
|
Ohhh I see there are two generated files... |
This fixes the core bug causing builds to race right now; the golang compiler might see a partially written file.
|
OK I think this one works. It's rather unfortunate I didn't hit these race conditions while building locally (I think my computer is too fast), nor in the original PR. |
|
My computer must be slow because I hit this 😞 With the PR I can build cosa now. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mike-nguyen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes the core bug causing builds to race right now; the
golang compiler might see a partially written file.