Skip to content

build: Fix race in generating schema#1309

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:schema-race
Apr 1, 2020
Merged

build: Fix race in generating schema#1309
openshift-merge-robot merged 1 commit intocoreos:masterfrom
cgwalters:schema-race

Conversation

@cgwalters
Copy link
Copy Markdown
Member

This fixes the core bug causing builds to race right now; the
golang compiler might see a partially written file.

@cgwalters
Copy link
Copy Markdown
Member Author

OK so this PR should fix the issues stalling other PRs; it will work without merging one of the other two options:

But after this lands we should pick one of those two.

@cgwalters
Copy link
Copy Markdown
Member Author

Ohhh I see there are two generated files...

This fixes the core bug causing builds to race right now; the
golang compiler might see a partially written file.
@cgwalters
Copy link
Copy Markdown
Member Author

OK I think this one works. It's rather unfortunate I didn't hit these race conditions while building locally (I think my computer is too fast), nor in the original PR.

@mike-nguyen
Copy link
Copy Markdown
Member

My computer must be slow because I hit this 😞 With the PR I can build cosa now.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit acf37ed into coreos:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants